From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org, jack@suse.com,
jeffm@suse.com, okurz@suse.com, lpechacek@suse.com,
jtulak@redhat.com
Subject: Re: [PATCH v3 4/4] debian/rules: use the new sysconfdir configuration setting
Date: Thu, 24 May 2018 21:02:18 -0700 [thread overview]
Message-ID: <20180525040218.GS14384@magnolia> (raw)
In-Reply-To: <20180525031943.29440-5-mcgrof@kernel.org>
On Thu, May 24, 2018 at 08:19:43PM -0700, Luis R. Rodriguez wrote:
> Configuration file support requires setting --sysconfdir=/etc/ if your
> distribution expects mkfs.xfs.d directory to be in /etc.
>
> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
Looks good, thanks for putting this series together!
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> debian/rules | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/debian/rules b/debian/rules
> index cb4fa22c1584..599d7998052e 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -20,9 +20,9 @@ stdenv = @GZIP=-q; export GZIP;
>
> options = export DEBUG=-DNDEBUG DISTRIBUTION=debian \
> INSTALL_USER=root INSTALL_GROUP=root \
> - LOCAL_CONFIGURE_OPTIONS="--enable-readline=yes --enable-blkid=yes --disable-ubsan --disable-addrsan --disable-threadsan --enable-lto" ;
> + LOCAL_CONFIGURE_OPTIONS="--enable-readline=yes --enable-blkid=yes --disable-ubsan --disable-addrsan --disable-threadsan --enable-lto --sysconfdir=/etc/" ;
> diopts = $(options) \
> - export OPTIMIZER=-Os LOCAL_CONFIGURE_OPTIONS="--enable-gettext=no --disable-ubsan --disable-addrsan --disable-threadsan --enable-lto" ;
> + export OPTIMIZER=-Os LOCAL_CONFIGURE_OPTIONS="--enable-gettext=no --disable-ubsan --disable-addrsan --disable-threadsan --enable-lto --sysconfdir=/etc/" ;
> checkdir = test -f debian/rules
>
> build: build-arch build-indep
> --
> 2.16.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-05-25 4:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 3:19 [PATCH v3 0/4] xfsprogs: add mkfs.xfs configuration file parsing support Luis R. Rodriguez
2018-05-25 3:19 ` [PATCH v3 1/4] mkfs: distinguish between struct sb_feat_args and struct cli_params Luis R. Rodriguez
2018-05-25 3:34 ` Darrick J. Wong
2018-05-25 3:19 ` [PATCH v3 2/4] mkfs: move shared config structs and into their own headers Luis R. Rodriguez
2018-05-25 3:35 ` Darrick J. Wong
2018-05-25 3:38 ` Luis R. Rodriguez
2018-05-25 3:19 ` [PATCH v3 3/4] mkfs.xfs: add configuration file parsing support using our own parser Luis R. Rodriguez
2018-05-25 4:01 ` Darrick J. Wong
2018-05-25 23:33 ` Luis R. Rodriguez
2018-05-26 0:05 ` Darrick J. Wong
2018-05-25 3:19 ` [PATCH v3 4/4] debian/rules: use the new sysconfdir configuration setting Luis R. Rodriguez
2018-05-25 4:02 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180525040218.GS14384@magnolia \
--to=darrick.wong@oracle.com \
--cc=jack@suse.com \
--cc=jeffm@suse.com \
--cc=jtulak@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=lpechacek@suse.com \
--cc=mcgrof@kernel.org \
--cc=okurz@suse.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).