From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
Toshi Kani <toshi.kani@hpe.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 1/7] fs: allow per-device dax status checking for filesystems
Date: Fri, 25 May 2018 09:42:29 -0600 [thread overview]
Message-ID: <20180525154229.GA11044@linux.intel.com> (raw)
In-Reply-To: <20180525050218.GF4507@magnolia>
On Thu, May 24, 2018 at 10:02:18PM -0700, Darrick J. Wong wrote:
> On Thu, May 24, 2018 at 08:55:12PM -0600, Ross Zwisler wrote:
> > From: "Darrick J. Wong" <darrick.wong@oracle.com>
> >
> > Remove __bdev_dax_supported and change to bdev_dax_supported that takes a
> > bdev parameter. This enables multi-device filesystems like xfs to check
> > that a dax device can work for the particular filesystem. Once that's
> > in place, actually fix all the parts of XFS where we need to be able to
> > distinguish between datadev and rtdev.
> >
> > This patch fixes the problem where we screw up the dax support checking
> > in xfs if the datadev and rtdev have different dax capabilities.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
>
> Reviewed-by: Darr...oh, I'm not allowed to do that, am I?
>
> Would you mind (re)sending this to the xfs list so that someone else can
> review it?
>
> --D
Thanks for the review, Darrick.
I think at one point Dave said that if you touch more than 1 filesystem with a
series you should just CC linux-fsdevel and omit the individual filesystems?
I realize that this series only touches ext2 and ext4 a little, but that's
what I opted for.
Is that sufficient to get to the rest of the XFS developers, or would you like
a resend adding linux-xfs?
next prev parent reply other threads:[~2018-05-25 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180525025518.11405-1-ross.zwisler@linux.intel.com>
[not found] ` <20180525025518.11405-2-ross.zwisler@linux.intel.com>
2018-05-25 5:02 ` [PATCH 1/7] fs: allow per-device dax status checking for filesystems Darrick J. Wong
2018-05-25 15:42 ` Ross Zwisler [this message]
2018-05-25 19:23 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180525154229.GA11044@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=darrick.wong@oracle.com \
--cc=dm-devel@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=snitzer@redhat.com \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).