Re: [PATCH 07/18] xfs: remove the now unused XFS_BMAPI_IGSTATE flag

Christoph Hellwig
2018-05-31T16:05:09Z

On Thu, May 31, 2018 at 09:46:38AM -0400, Brian Foster wrote:
> On Wed, May 30, 2018 at 12:00:02PM +0200, Christoph Hellwig wrote:
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
>
> The change looks Ok... It's clearly reasonable to remove a flag that is
> no longer used, but why is it no longer used? The previous patch drops
> it to "make xfs_writepage_map() extent map centric," but the description
> doesn't exactly explain why (and it's not immediately clear to me
> amongst all the other code changes).

My refactoring moves this into a separate patch with a proper changelog,
I'll send it out in a bit.