From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org,
Andreas Gruenbacher <agruenba@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/3] fs: remove the buffer_unwritten check in page_seek_hole_data
Date: Thu, 31 May 2018 08:47:06 +1000 [thread overview]
Message-ID: <20180530224706.GX10363@dastard> (raw)
In-Reply-To: <20180530100208.31490-3-hch@lst.de>
On Wed, May 30, 2018 at 12:02:07PM +0200, Christoph Hellwig wrote:
> We only call into this function through the iomap iterators, so we already
> know the buffer is unwritten. In addition to that we always require the
> uptodate flag that is ORed with the result anyway.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/iomap.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
Makes sense to me.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-05-30 22:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 10:02 iomap SEEK_HOLE / SEEK_DATA cleanups and generalization Christoph Hellwig
2018-05-30 10:02 ` [PATCH 1/3] fs: move page_cache_seek_hole_data to iomap.c Christoph Hellwig
2018-05-30 22:46 ` Dave Chinner
2018-05-30 10:02 ` [PATCH 2/3] fs: remove the buffer_unwritten check in page_seek_hole_data Christoph Hellwig
2018-05-30 22:47 ` Dave Chinner [this message]
2018-05-30 10:02 ` [PATCH 3/3] fs: use ->is_partially_uptodate in page_cache_seek_hole_data Christoph Hellwig
2018-05-30 13:48 ` Andreas Grünbacher
2018-05-30 23:00 ` Dave Chinner
2018-05-31 6:20 ` Christoph Hellwig
2018-05-30 16:07 ` iomap SEEK_HOLE / SEEK_DATA cleanups and generalization Darrick J. Wong
2018-05-30 16:17 ` Christoph Hellwig
2018-05-30 16:25 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2018-05-31 18:07 iomap SEEK_HOLE / SEEK_DATA cleanups and generalization v2 Christoph Hellwig
2018-05-31 18:07 ` [PATCH 2/3] fs: remove the buffer_unwritten check in page_seek_hole_data Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180530224706.GX10363@dastard \
--to=david@fromorbit.com \
--cc=agruenba@redhat.com \
--cc=hch@lst.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).