* [PATCH] xfs_db: handle realtime bitmap / summary files as text
@ 2018-05-31 15:57 Darrick J. Wong
2018-05-31 16:02 ` Eric Sandeen
2018-05-31 16:05 ` Bill O'Donnell
0 siblings, 2 replies; 3+ messages in thread
From: Darrick J. Wong @ 2018-05-31 15:57 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs
From: Darrick J. Wong <darrick.wong@oracle.com>
Use handle_text to print realtime bitmap / summary file blocks instead
of erroring out.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
db/type.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/db/type.c b/db/type.c
index 8b2f7b2f..7045d829 100644
--- a/db/type.c
+++ b/db/type.c
@@ -71,8 +71,8 @@ static const typ_t __typtab[] = {
{ TYP_INODATA, "inodata", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
{ TYP_INODE, "inode", handle_struct, inode_hfld, NULL, TYP_F_NO_CRC_OFF },
{ TYP_LOG, "log", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
- { TYP_RTBITMAP, "rtbitmap", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
- { TYP_RTSUMMARY, "rtsummary", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
+ { TYP_RTBITMAP, "rtbitmap", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
+ { TYP_RTSUMMARY, "rtsummary", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
{ TYP_SB, "sb", handle_struct, sb_hfld, NULL, TYP_F_NO_CRC_OFF },
{ TYP_SYMLINK, "symlink", handle_string, NULL, NULL, TYP_F_NO_CRC_OFF },
{ TYP_TEXT, "text", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
@@ -115,8 +115,8 @@ static const typ_t __typtab_crc[] = {
{ TYP_INODE, "inode", handle_struct, inode_crc_hfld,
&xfs_inode_buf_ops, TYP_F_CRC_FUNC, xfs_inode_set_crc },
{ TYP_LOG, "log", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
- { TYP_RTBITMAP, "rtbitmap", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
- { TYP_RTSUMMARY, "rtsummary", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
+ { TYP_RTBITMAP, "rtbitmap", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
+ { TYP_RTSUMMARY, "rtsummary", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
{ TYP_SB, "sb", handle_struct, sb_hfld, &xfs_sb_buf_ops,
XFS_SB_CRC_OFF },
{ TYP_SYMLINK, "symlink", handle_struct, symlink_crc_hfld,
@@ -161,8 +161,8 @@ static const typ_t __typtab_spcrc[] = {
{ TYP_INODE, "inode", handle_struct, inode_crc_hfld,
&xfs_inode_buf_ops, TYP_F_CRC_FUNC, xfs_inode_set_crc },
{ TYP_LOG, "log", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
- { TYP_RTBITMAP, "rtbitmap", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
- { TYP_RTSUMMARY, "rtsummary", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
+ { TYP_RTBITMAP, "rtbitmap", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
+ { TYP_RTSUMMARY, "rtsummary", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
{ TYP_SB, "sb", handle_struct, sb_hfld, &xfs_sb_buf_ops,
XFS_SB_CRC_OFF },
{ TYP_SYMLINK, "symlink", handle_struct, symlink_crc_hfld,
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] xfs_db: handle realtime bitmap / summary files as text
2018-05-31 15:57 [PATCH] xfs_db: handle realtime bitmap / summary files as text Darrick J. Wong
@ 2018-05-31 16:02 ` Eric Sandeen
2018-05-31 16:05 ` Bill O'Donnell
1 sibling, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2018-05-31 16:02 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: xfs
On 5/31/18 10:57 AM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Use handle_text to print realtime bitmap / summary file blocks instead
> of erroring out.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> db/type.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/db/type.c b/db/type.c
> index 8b2f7b2f..7045d829 100644
> --- a/db/type.c
> +++ b/db/type.c
> @@ -71,8 +71,8 @@ static const typ_t __typtab[] = {
> { TYP_INODATA, "inodata", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
> { TYP_INODE, "inode", handle_struct, inode_hfld, NULL, TYP_F_NO_CRC_OFF },
> { TYP_LOG, "log", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
> - { TYP_RTBITMAP, "rtbitmap", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
> - { TYP_RTSUMMARY, "rtsummary", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
> + { TYP_RTBITMAP, "rtbitmap", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
> + { TYP_RTSUMMARY, "rtsummary", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
> { TYP_SB, "sb", handle_struct, sb_hfld, NULL, TYP_F_NO_CRC_OFF },
> { TYP_SYMLINK, "symlink", handle_string, NULL, NULL, TYP_F_NO_CRC_OFF },
> { TYP_TEXT, "text", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
> @@ -115,8 +115,8 @@ static const typ_t __typtab_crc[] = {
> { TYP_INODE, "inode", handle_struct, inode_crc_hfld,
> &xfs_inode_buf_ops, TYP_F_CRC_FUNC, xfs_inode_set_crc },
> { TYP_LOG, "log", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
> - { TYP_RTBITMAP, "rtbitmap", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
> - { TYP_RTSUMMARY, "rtsummary", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
> + { TYP_RTBITMAP, "rtbitmap", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
> + { TYP_RTSUMMARY, "rtsummary", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
> { TYP_SB, "sb", handle_struct, sb_hfld, &xfs_sb_buf_ops,
> XFS_SB_CRC_OFF },
> { TYP_SYMLINK, "symlink", handle_struct, symlink_crc_hfld,
> @@ -161,8 +161,8 @@ static const typ_t __typtab_spcrc[] = {
> { TYP_INODE, "inode", handle_struct, inode_crc_hfld,
> &xfs_inode_buf_ops, TYP_F_CRC_FUNC, xfs_inode_set_crc },
> { TYP_LOG, "log", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
> - { TYP_RTBITMAP, "rtbitmap", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
> - { TYP_RTSUMMARY, "rtsummary", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
> + { TYP_RTBITMAP, "rtbitmap", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
> + { TYP_RTSUMMARY, "rtsummary", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
> { TYP_SB, "sb", handle_struct, sb_hfld, &xfs_sb_buf_ops,
> XFS_SB_CRC_OFF },
> { TYP_SYMLINK, "symlink", handle_struct, symlink_crc_hfld,
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] xfs_db: handle realtime bitmap / summary files as text
2018-05-31 15:57 [PATCH] xfs_db: handle realtime bitmap / summary files as text Darrick J. Wong
2018-05-31 16:02 ` Eric Sandeen
@ 2018-05-31 16:05 ` Bill O'Donnell
1 sibling, 0 replies; 3+ messages in thread
From: Bill O'Donnell @ 2018-05-31 16:05 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Eric Sandeen, xfs
On Thu, May 31, 2018 at 08:57:24AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Use handle_text to print realtime bitmap / summary file blocks instead
> of erroring out.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
> ---
> db/type.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/db/type.c b/db/type.c
> index 8b2f7b2f..7045d829 100644
> --- a/db/type.c
> +++ b/db/type.c
> @@ -71,8 +71,8 @@ static const typ_t __typtab[] = {
> { TYP_INODATA, "inodata", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
> { TYP_INODE, "inode", handle_struct, inode_hfld, NULL, TYP_F_NO_CRC_OFF },
> { TYP_LOG, "log", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
> - { TYP_RTBITMAP, "rtbitmap", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
> - { TYP_RTSUMMARY, "rtsummary", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
> + { TYP_RTBITMAP, "rtbitmap", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
> + { TYP_RTSUMMARY, "rtsummary", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
> { TYP_SB, "sb", handle_struct, sb_hfld, NULL, TYP_F_NO_CRC_OFF },
> { TYP_SYMLINK, "symlink", handle_string, NULL, NULL, TYP_F_NO_CRC_OFF },
> { TYP_TEXT, "text", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
> @@ -115,8 +115,8 @@ static const typ_t __typtab_crc[] = {
> { TYP_INODE, "inode", handle_struct, inode_crc_hfld,
> &xfs_inode_buf_ops, TYP_F_CRC_FUNC, xfs_inode_set_crc },
> { TYP_LOG, "log", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
> - { TYP_RTBITMAP, "rtbitmap", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
> - { TYP_RTSUMMARY, "rtsummary", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
> + { TYP_RTBITMAP, "rtbitmap", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
> + { TYP_RTSUMMARY, "rtsummary", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
> { TYP_SB, "sb", handle_struct, sb_hfld, &xfs_sb_buf_ops,
> XFS_SB_CRC_OFF },
> { TYP_SYMLINK, "symlink", handle_struct, symlink_crc_hfld,
> @@ -161,8 +161,8 @@ static const typ_t __typtab_spcrc[] = {
> { TYP_INODE, "inode", handle_struct, inode_crc_hfld,
> &xfs_inode_buf_ops, TYP_F_CRC_FUNC, xfs_inode_set_crc },
> { TYP_LOG, "log", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
> - { TYP_RTBITMAP, "rtbitmap", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
> - { TYP_RTSUMMARY, "rtsummary", NULL, NULL, NULL, TYP_F_NO_CRC_OFF },
> + { TYP_RTBITMAP, "rtbitmap", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
> + { TYP_RTSUMMARY, "rtsummary", handle_text, NULL, NULL, TYP_F_NO_CRC_OFF },
> { TYP_SB, "sb", handle_struct, sb_hfld, &xfs_sb_buf_ops,
> XFS_SB_CRC_OFF },
> { TYP_SYMLINK, "symlink", handle_struct, symlink_crc_hfld,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-31 16:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-31 15:57 [PATCH] xfs_db: handle realtime bitmap / summary files as text Darrick J. Wong
2018-05-31 16:02 ` Eric Sandeen
2018-05-31 16:05 ` Bill O'Donnell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox