From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Eric Sandeen <sandeen@sandeen.net>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 0/4 V2] Remove a few macros
Date: Thu, 31 May 2018 16:22:29 -0700 [thread overview]
Message-ID: <20180531232229.GE7825@magnolia> (raw)
In-Reply-To: <20180531231153.GO10363@dastard>
On Fri, Jun 01, 2018 at 09:11:53AM +1000, Dave Chinner wrote:
> On Thu, May 31, 2018 at 07:19:09PM +0200, Carlos Maiolino wrote:
> > On Thu, May 31, 2018 at 11:58:51AM -0500, Eric Sandeen wrote:
> > > On 3/7/18 3:05 AM, Carlos Maiolino wrote:
> > > > Hi,
> > > >
> > > > this is a second version of the patchset aimed to clean up some old macros from
> > > > xfsprogs, as the objective to bring xfs_buf handling code closer to kernel code.
> > > >
> > > > It fixes some pointer castings Dave mentioned on the V1 patch, also, it removes
> > > > a few unneeded castings I spotted while reviewing the ones Dave mentioned.
> > > >
> > > > Cheers
> > > >
> > > > Carlos Maiolino (4):
> > > > Get rid of XFS_BUF_PTR() macro
> > > > Get rid of XFS_BUF_TARGET() macro
> > > > get rid of XFS_BUF_COUNT() macro
> > > > Get rid of XFS_BUF_SET_COUNT() macro
> > >
> > > Sorry, I'd still like to merge these but they need a rebase now.
> > > And did the casting-wars between dchinner & hch ever get resolved?
> > >
> >
> >
> > I don't know actually, I don't remember seeing Dave replying agreeing or not
> > with hch
>
> What was there to argue? Christoph wants us to rely on undocumented,
> compiler specific behaviour(*), I want it the pointer arithmetic to
> be explicitly correct with a cast.
>
> Maintainer's choice, really.
Explicit (char *) cast so it works correctly, please. :)
--D
> Cheers,
>
> Dave.
>
> (*) It's been repeatedly demonstrated that the gcc developers don't
> care if they break code that relies on undefined behaviour in the C
> standard.
> --
> Dave Chinner
> david@fromorbit.com
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-05-31 23:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 9:05 [PATCH 0/4 V2] Remove a few macros Carlos Maiolino
2018-03-07 9:05 ` [PATCH 1/4] Get rid of XFS_BUF_PTR() macro Carlos Maiolino
2018-03-07 9:05 ` [PATCH 2/4] Get rid of XFS_BUF_TARGET() macro Carlos Maiolino
2018-03-07 9:05 ` [PATCH 3/4] get rid of XFS_BUF_COUNT() macro Carlos Maiolino
2018-03-07 9:05 ` [PATCH 4/4] Get rid of XFS_BUF_SET_COUNT() macro Carlos Maiolino
2018-05-31 16:58 ` [PATCH 0/4 V2] Remove a few macros Eric Sandeen
2018-05-31 17:19 ` Carlos Maiolino
2018-05-31 23:11 ` Dave Chinner
2018-05-31 23:22 ` Darrick J. Wong [this message]
2018-06-01 5:25 ` Christoph Hellwig
2018-07-24 0:06 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180531232229.GE7825@magnolia \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).