From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2130.oracle.com ([156.151.31.86]:54942 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750714AbeEaXWf (ORCPT ); Thu, 31 May 2018 19:22:35 -0400 Date: Thu, 31 May 2018 16:22:29 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH 0/4 V2] Remove a few macros Message-ID: <20180531232229.GE7825@magnolia> References: <20180307090506.30199-1-cmaiolino@redhat.com> <20180531171909.cedwobpqlaf2h5ly@odin.usersys.redhat.com> <20180531231153.GO10363@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180531231153.GO10363@dastard> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Dave Chinner Cc: Eric Sandeen , linux-xfs@vger.kernel.org On Fri, Jun 01, 2018 at 09:11:53AM +1000, Dave Chinner wrote: > On Thu, May 31, 2018 at 07:19:09PM +0200, Carlos Maiolino wrote: > > On Thu, May 31, 2018 at 11:58:51AM -0500, Eric Sandeen wrote: > > > On 3/7/18 3:05 AM, Carlos Maiolino wrote: > > > > Hi, > > > > > > > > this is a second version of the patchset aimed to clean up some old macros from > > > > xfsprogs, as the objective to bring xfs_buf handling code closer to kernel code. > > > > > > > > It fixes some pointer castings Dave mentioned on the V1 patch, also, it removes > > > > a few unneeded castings I spotted while reviewing the ones Dave mentioned. > > > > > > > > Cheers > > > > > > > > Carlos Maiolino (4): > > > > Get rid of XFS_BUF_PTR() macro > > > > Get rid of XFS_BUF_TARGET() macro > > > > get rid of XFS_BUF_COUNT() macro > > > > Get rid of XFS_BUF_SET_COUNT() macro > > > > > > Sorry, I'd still like to merge these but they need a rebase now. > > > And did the casting-wars between dchinner & hch ever get resolved? > > > > > > > > > I don't know actually, I don't remember seeing Dave replying agreeing or not > > with hch > > What was there to argue? Christoph wants us to rely on undocumented, > compiler specific behaviour(*), I want it the pointer arithmetic to > be explicitly correct with a cast. > > Maintainer's choice, really. Explicit (char *) cast so it works correctly, please. :) --D > Cheers, > > Dave. > > (*) It's been repeatedly demonstrated that the gcc developers don't > care if they break code that relies on undefined behaviour in the C > standard. > -- > Dave Chinner > david@fromorbit.com > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html