From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2120.oracle.com ([156.151.31.85]:52268 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779AbeFDEZ3 (ORCPT ); Mon, 4 Jun 2018 00:25:29 -0400 Date: Sun, 3 Jun 2018 21:25:25 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH 01/10] xfs: don't forbid setting dax flag on directories if device doesn't dax Message-ID: <20180604042525.GM7825@magnolia> References: <152806814253.18187.4009340462930782844.stgit@magnolia> <152806814871.18187.4240645095990301961.stgit@magnolia> <20180603234136.GX10363@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180603234136.GX10363@dastard> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Dave Chinner Cc: linux-xfs@vger.kernel.org On Mon, Jun 04, 2018 at 09:41:36AM +1000, Dave Chinner wrote: > On Sun, Jun 03, 2018 at 04:22:28PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong > > > > On a directory, the DAX flag is merely a hint that files created in the > > directory should have the DAX flag set at creation time. We don't care > > if the underlying device supports DAX or not because directory metadata > > are always cached in DRAM. We don't care if new files get the flag even > > if the device doesn't support DAX because we always check for DAX > > support before setting the VFS flag (S_DAX). > > > > Signed-off-by: Darrick J. Wong > > Am I correct in assuming this allows directory hints to work on > a filesystem with a DAX capable RT device, but a normal data device? Correct. --D > Regardless, behaviour seems sensible to me. > > Reviewed-by: Dave Chinner > -- > Dave Chinner > david@fromorbit.com > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html