From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/4] xfs: check directory bestfree information in the verifier
Date: Tue, 5 Jun 2018 07:56:08 +1000 [thread overview]
Message-ID: <20180604215608.GQ10363@dastard> (raw)
In-Reply-To: <152812862797.2736.1635127719444719703.stgit@magnolia>
On Mon, Jun 04, 2018 at 09:10:28AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Create a variant of xfs_dir2_data_freefind that is suitable for use in a
> verifier. Because _freefind is called by the verifier, we simply
> duplicate the _freefind function, convert the ASSERTs to return
> __this_address, and modify the verifier to call our new function. Once
> we've made it impossible for directory blocks with bad bestfree data to
> make it into the filesystem we can remove the DEBUG code from the
> regular _freefind function.
>
> Underlying argument: corruption of on-disk metadata should return
> -EFSCORRUPTED instead of blowing ASSERTs.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-06-04 21:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 16:10 [PATCH v2 0/4] xfs: fix various checking problems Darrick J. Wong
2018-06-04 16:10 ` [PATCH 1/4] xfs: check directory bestfree information in the verifier Darrick J. Wong
2018-06-04 21:56 ` Dave Chinner [this message]
2018-06-04 16:10 ` [PATCH 2/4] xfs: introduce xfs_btree_debug_check_ptr Darrick J. Wong
2018-06-04 21:56 ` Dave Chinner
2018-06-04 16:10 ` [PATCH 3/4] xfs: don't assert when on-disk btree pointers are garbage Darrick J. Wong
2018-06-04 21:57 ` Dave Chinner
2018-06-04 16:10 ` [PATCH 4/4] xfs: strengthen btree pointer checks before use Darrick J. Wong
2018-06-04 21:58 ` Dave Chinner
2018-06-04 19:17 ` [PATCH 5/4] xfs: explicitly pass buffer size to xfs_corruption_error Darrick J. Wong
2018-06-04 22:00 ` Dave Chinner
2018-06-04 19:17 ` [PATCH 6/4] xfs: don't assert on corrupted unlinked inode list Darrick J. Wong
2018-06-04 22:03 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180604215608.GQ10363@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox