From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: use xfs_trans_getsb in xfs_sync_sb_buf
Date: Tue, 5 Jun 2018 10:56:47 +1000 [thread overview]
Message-ID: <20180605005647.GX10363@dastard> (raw)
In-Reply-To: <bd3ee55c-30a4-4e45-10fc-3458c7b93a1d@redhat.com>
On Mon, Jun 04, 2018 at 06:50:05PM -0500, Eric Sandeen wrote:
> Use xfs_trans_getsb rather than reaching right in for
> mp->m_sb_bp; I think this is more correct, and it facilitates
> building this libxfs code in userspace as well.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> This passes the online label test ... tbh I'm not quite
> sure if I'm unwinding/unlocking/putting the bp properly
> here, though, so ... eyes & advice appreciated?
I think it's ok - the transaction context is gone with the commit,
so xfs_trans_brelse() would just call xfs_buf_relse() anyway.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2018-06-05 0:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 23:50 [PATCH] xfs: use xfs_trans_getsb in xfs_sync_sb_buf Eric Sandeen
2018-06-05 0:56 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605005647.GX10363@dastard \
--to=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox