From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 0/3] xfs: more verifications!
Date: Mon, 4 Jun 2018 20:38:00 -0700 [thread overview]
Message-ID: <20180605033800.GA9437@magnolia> (raw)
In-Reply-To: <20180605024313.18737-1-david@fromorbit.com>
On Tue, Jun 05, 2018 at 12:43:10PM +1000, Dave Chinner wrote:
> Hi folks,
>
> This patchset addresses a series of corruptions noticed in an image
> provided by Wen Xu. The patches only address detecting corruptions
> before they can do damage - it does not address/fix the crash the
> image caused but instead prevents the bad information from getting
> to the point where it can cause a crash.
>
> The third patch addresses a general btree record validation issue;
> we should probably dirve this inwards to each btree implementation
> with a ->verify_record() callout, as this patch does not address
> all the places that btree records are traversed during searches. It
> will catch any attempt to use a bad record that a search lands on,
> however.
>
> Comments?
So, uh, does xfs_repair catch all these things and fix them?
I wonder if online repair catches and fixes them too, but I won't yet
start heckling people about that. :P
--D
> -Dave.
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-06-05 3:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 2:43 [PATCH 0/3] xfs: more verifications! Dave Chinner
2018-06-05 2:43 ` [PATCH 1/3] xfs: catch bad stripe alignment configurations Dave Chinner
2018-06-05 3:44 ` Darrick J. Wong
2018-06-05 2:43 ` [PATCH 2/3] xfs: verify extent size hint is valid in inode verifier Dave Chinner
2018-06-05 4:08 ` Darrick J. Wong
2018-06-05 4:24 ` Dave Chinner
2018-06-05 4:28 ` Darrick J. Wong
2018-06-05 4:47 ` Dave Chinner
2018-06-05 2:43 ` [PATCH 3/3] xfs: validate btree records on retreival Dave Chinner
2018-06-05 4:02 ` Darrick J. Wong
2018-06-05 4:39 ` Dave Chinner
2018-06-05 5:08 ` Dave Chinner
2018-06-05 2:57 ` [PATCH 4/3] xfs: verify root inode more thoroughly Dave Chinner
2018-06-05 4:06 ` Darrick J. Wong
2018-06-05 5:30 ` Dave Chinner
2018-06-05 3:38 ` Darrick J. Wong [this message]
2018-06-05 4:44 ` [PATCH 0/3] xfs: more verifications! Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605033800.GA9437@magnolia \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox