public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <guaneryu@gmail.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 5/6] xfs: abstract xfs_info into $XFS_INFO_PROG
Date: Thu, 7 Jun 2018 19:37:13 +0800	[thread overview]
Message-ID: <20180607113713.GA1103@desktop> (raw)
In-Reply-To: <152821700731.24976.1667061625518547754.stgit@magnolia>

On Tue, Jun 05, 2018 at 09:43:27AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Abstract calls to xfs_info into $XFS_INFO_PROG like we do for all other
> xfs utilities.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>  common/attr      |    2 +-
>  common/config    |    1 +
>  common/populate  |   18 +++++++++---------
>  common/rc        |    2 +-

Better to make xfs_info mandatory too when testing xfs, so I did the
below diff on commit

diff --git a/common/rc b/common/rc
index f04c9ea2fd89..9d6665b6c4d7 100644
--- a/common/rc
+++ b/common/rc
@@ -136,6 +136,7 @@ case "$FSTYP" in
         [ "$XFS_REPAIR_PROG" = "" ] && _fatal "xfs_repair not found"
         [ "$XFS_DB_PROG" = "" ] && _fatal "xfs_db not found"
         [ "$MKFS_XFS_PROG" = "" ] && _fatal "mkfs_xfs not found"
+        [ "$XFS_INFO_PROG" = "" ] && _fatal "xfs_info not found"

         . ./common/xfs
         ;;

Thanks,
Eryu

  reply	other threads:[~2018-06-07 11:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-05 16:42 [PATCH 0/6] fstests: fixes and new tests Darrick J. Wong
2018-06-05 16:42 ` [PATCH 1/6] xfs/439: don't check filesystem afterwards Darrick J. Wong
2018-06-05 16:43 ` [PATCH 2/6] xfs/122: fix sb_fname[XFSLABEL_MAX] in test Darrick J. Wong
2018-06-05 16:43 ` [PATCH 3/6] xfs/310: fix _require_scratch_nocheck ordering Darrick J. Wong
2018-06-05 16:43 ` [PATCH 4/6] generic: test swapfile creation, activation, and deactivation Darrick J. Wong
2018-06-07 12:34   ` Eryu Guan
2018-06-07 15:01     ` Darrick J. Wong
2018-06-07 15:17   ` [PATCH v2 " Darrick J. Wong
2018-06-05 16:43 ` [PATCH 5/6] xfs: abstract xfs_info into $XFS_INFO_PROG Darrick J. Wong
2018-06-07 11:37   ` Eryu Guan [this message]
2018-06-07 15:03     ` Darrick J. Wong
2018-06-05 16:43 ` [PATCH 6/6] xfs: make sure pretty printed geometry output matches Darrick J. Wong
2018-06-07 12:48   ` Eryu Guan
2018-06-07 15:13     ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180607113713.GA1103@desktop \
    --to=guaneryu@gmail.com \
    --cc=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox