From: Dave Chinner <david@fromorbit.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org,
darrick.wong@oracle.com, jack@suse.com, jeffm@suse.com,
okurz@suse.com, lpechacek@suse.com, jtulak@redhat.com
Subject: Re: [PATCH v5 4/4] mkfs.xfs: add configuration file parsing support using our own parser
Date: Sat, 9 Jun 2018 08:18:34 +1000 [thread overview]
Message-ID: <20180608221833.GB10363@dastard> (raw)
In-Reply-To: <20180607235533.20391-5-mcgrof@kernel.org>
Just because Eric questioned this on IRC:
On Thu, Jun 07, 2018 at 04:55:33PM -0700, Luis R. Rodriguez wrote:
> - /* copy new defaults into CLI parsing structure */
> + /*
> + * Pull config line options from command line
> + */
> + while ((c = getopt(argc, argv, "b:c:d:i:l:L:m:n:KNp:qr:s:CfV")) != EOF) {
opterr = 0;
while ((c = getopt(argc, argv, "c:")) != EOF) {
And then reset opterr = 1 when optind gets reset so it warns about
unknown options again.
It's in the man page!
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-06-08 22:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 23:55 [PATCH v5 0/4] xfsprogs: add mkfs.xfs configuration file parsing support Luis R. Rodriguez
2018-06-07 23:55 ` [PATCH v5 1/4] mkfs: distinguish between struct sb_feat_args and struct cli_params Luis R. Rodriguez
2018-06-07 23:55 ` [PATCH v5 2/4] mkfs: move shared config structs and into their own headers Luis R. Rodriguez
2018-06-07 23:55 ` [PATCH v5 3/4] mkfs: replace defaults source with an enum Luis R. Rodriguez
2018-06-07 23:55 ` [PATCH v5 4/4] mkfs.xfs: add configuration file parsing support using our own parser Luis R. Rodriguez
2018-06-08 22:18 ` Dave Chinner [this message]
2018-06-11 23:12 ` Eric Sandeen
2018-06-12 0:23 ` Luis R. Rodriguez
2018-06-12 1:02 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180608221833.GB10363@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=jack@suse.com \
--cc=jeffm@suse.com \
--cc=jtulak@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=lpechacek@suse.com \
--cc=mcgrof@kernel.org \
--cc=okurz@suse.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox