From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp2130.oracle.com ([141.146.126.79]:41350 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933462AbeFKRoD (ORCPT ); Mon, 11 Jun 2018 13:44:03 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w5BHefSw191057 for ; Mon, 11 Jun 2018 17:44:02 GMT Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp2130.oracle.com with ESMTP id 2jg4dkxpyb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 11 Jun 2018 17:44:02 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w5BHi1n5003678 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 11 Jun 2018 17:44:01 GMT Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w5BHi0li025598 for ; Mon, 11 Jun 2018 17:44:01 GMT Date: Mon, 11 Jun 2018 10:43:59 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH v2 20/27] xfsprogs: Add parent pointer flag to cmd Message-ID: <20180611174359.GD22045@magnolia> References: <1528607272-11122-1-git-send-email-allison.henderson@oracle.com> <1528607272-11122-21-git-send-email-allison.henderson@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1528607272-11122-21-git-send-email-allison.henderson@oracle.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Allison Henderson Cc: linux-xfs@vger.kernel.org On Sat, Jun 09, 2018 at 10:07:45PM -0700, Allison Henderson wrote: > mkfs: enable formatting with parent pointers > Enable parent pointer support in mkfs via the '-n parent' parameter. > > Signed-off-by: Allison Henderson > --- > mkfs/xfs_mkfs.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c > index 78d0ce5..b9a8b00 100644 > --- a/mkfs/xfs_mkfs.c > +++ b/mkfs/xfs_mkfs.c > @@ -104,6 +104,7 @@ enum { > N_SIZE = 0, > N_VERSION, > N_FTYPE, > + N_PARENT, > N_MAX_OPTS, > }; > > @@ -550,6 +551,7 @@ struct opt_params nopts = { > [N_SIZE] = "size", > [N_VERSION] = "version", > [N_FTYPE] = "ftype", > + [N_PARENT] = "parent", > }, > .subopt_params = { > { .index = N_SIZE, > @@ -572,6 +574,12 @@ struct opt_params nopts = { > .maxval = 1, > .defaultval = 1, > }, > + { .index = N_PARENT, > + .conflicts = { { NULL, LAST_CONFLICT } }, > + .minval = 0, > + .maxval = 1, > + .defaultval = 1, > + }, > }, > }; > > @@ -876,7 +884,7 @@ usage( void ) > /* log subvol */ [-l agnum=n,internal,size=num,logdev=xxx,version=n\n\ > sunit=value|su=num,sectsize=num,lazy-count=0|1]\n\ > /* label */ [-L label (maximum 12 characters)]\n\ > -/* naming */ [-n size=num,version=2|ci,ftype=0|1]\n\ > +/* naming */ [-n size=num,version=2|ci,ftype=0|1,parent=0|1]\n\ > /* no-op info only */ [-N]\n\ > /* prototype file */ [-p fname]\n\ > /* quiet */ [-q]\n\ > @@ -1615,6 +1623,9 @@ naming_opts_parser( > case N_FTYPE: > cli->sb_feat.dirftype = getnum(value, opts, subopt); > break; > + case N_PARENT: > + cli->sb_feat.parent_pointers = getnum(value, &nopts, N_PARENT); > + break; > default: > return -EINVAL; > } validate_sb_features() needs to disallow parent pointers on v4 filesystems. See "reflink not supported without CRC support" around xfs_mkfs.c line 2015. --D > @@ -2887,6 +2898,8 @@ sb_set_features( > sbp->sb_features_ro_compat |= XFS_SB_FEAT_RO_COMPAT_RMAPBT; > if (fp->reflink) > sbp->sb_features_ro_compat |= XFS_SB_FEAT_RO_COMPAT_REFLINK; > + if (fp->parent_pointers) > + sbp->sb_features_ro_compat |= XFS_SB_FEAT_RO_COMPAT_PARENT; > > /* > * Sparse inode chunk support has two main inode alignment requirements. > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html