linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH v2 0/2] xfs: fix buffer delwri queue state race
Date: Wed, 13 Jun 2018 07:05:14 -0400	[thread overview]
Message-ID: <20180613110516.65494-1-bfoster@redhat.com> (raw)

Hi all,

Here's a v2 of the patches to fix the buffer delwri queue state race
problem (documented in the patch 2 commit log). This takes a completely
different approach from v1, as suggested by Dave during review of v1.

Patch 1 refactors the buffer submission paths and patch 2 closes the
race by using synchronous buffer I/O for synchronous delwri queues. This
survives a full xfstests run as well as lowmem stress testing of
xfs/305 [1].

Thoughts, reviews, flames appreciated.

Brian

[1] If run long enough, I do eventually hit some presumably unrelated
issues that are not currently reproducible simply due to the fact that
the delwri queue issue is more prevalent.

v2:
- Implement sync buffer I/O for sync delwri queues instead of buffer
  wait list stealing.
v1: https://marc.info/?l=linux-xfs&m=152837528705511&w=2

Brian Foster (2):
  xfs: refactor buffer submission into a common helper
  xfs: use sync buffer I/O for sync delwri queue submission

 fs/xfs/xfs_buf.c | 164 +++++++++++++++++++++++------------------------
 1 file changed, 79 insertions(+), 85 deletions(-)

-- 
2.17.1


             reply	other threads:[~2018-06-13 11:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-13 11:05 Brian Foster [this message]
2018-06-13 11:05 ` [PATCH v2 1/2] xfs: refactor buffer submission into a common helper Brian Foster
2018-06-14 13:43   ` [PATCH v3 " Brian Foster
2018-06-15 11:24     ` Christoph Hellwig
2018-06-15 11:53       ` Brian Foster
2018-06-13 11:05 ` [PATCH v2 2/2] xfs: use sync buffer I/O for sync delwri queue submission Brian Foster
2018-06-13 22:08   ` Dave Chinner
2018-06-13 23:29     ` Brian Foster
2018-06-13 23:37       ` Dave Chinner
2018-06-15 11:28   ` Christoph Hellwig
2018-06-15 11:53     ` Brian Foster
2018-06-15 12:16       ` Christoph Hellwig
2018-06-15 12:39         ` Brian Foster
2018-06-15 16:31           ` Darrick J. Wong
2018-06-15 17:43             ` Brian Foster
2018-06-18 11:21           ` Christoph Hellwig
2018-06-18 11:47             ` Brian Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180613110516.65494-1-bfoster@redhat.com \
    --to=bfoster@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).