From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] mkfs: initialize return value of parse_config_stream to success
Date: Thu, 14 Jun 2018 09:41:36 -0700 [thread overview]
Message-ID: <20180614164136.GD6825@magnolia> (raw)
In-Reply-To: <8318bdfe-ff7b-02b9-414e-f63f9ccdbdbc@sandeen.net>
On Wed, Jun 13, 2018 at 02:34:33PM -0500, Eric Sandeen wrote:
> Right now the return value is initialized to -1 (failure) and set to zero
> only if a valid token is found. However, this means that i.e. a blank
> or template config file containing only comments will yield failure on
> parsing.
>
> Initialize to success, and set to failure only if failure occurs.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
>
> diff --git a/mkfs/config.c b/mkfs/config.c
> index 835adc4..1a2cd35 100644
> --- a/mkfs/config.c
> +++ b/mkfs/config.c
> @@ -385,7 +385,7 @@ parse_config_stream(
> const char *config_file,
> FILE *fp)
> {
> - int ret = -1;
> + int ret = 0;
> char *line = NULL;
> ssize_t linelen;
> size_t len = 0, lineno = 0;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-06-14 16:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 19:33 [PATCH 0/2] mkfs: 2 more fixes Eric Sandeen
2018-06-13 19:34 ` [PATCH 1/2] mkfs: initialize return value of parse_config_stream to success Eric Sandeen
2018-06-14 8:48 ` Carlos Maiolino
2018-06-14 16:20 ` Luis R. Rodriguez
2018-06-14 16:41 ` Darrick J. Wong [this message]
2018-06-13 19:37 ` [PATCH 2/2] mkfs: remove notion of config "type" Eric Sandeen
2018-06-14 9:46 ` Carlos Maiolino
2018-06-14 16:19 ` Luis R. Rodriguez
2018-06-14 16:40 ` Eric Sandeen
2018-06-14 16:41 ` Darrick J. Wong
2018-06-14 23:42 ` Dave Chinner
[not found] ` <CAB=NE6V7JmsPpkCB1zp0CuY5YTJvMonG7UJPjScKYVJZLWb3xg@mail.gmail.com>
2018-06-15 2:33 ` Dave Chinner
2018-06-15 2:45 ` Eric Sandeen
2018-06-16 0:17 ` Dave Chinner
2018-06-16 0:55 ` Eric Sandeen
2018-06-16 2:44 ` Dave Chinner
2018-06-16 4:35 ` cfg file versioning (was: [PATCH 2/2] mkfs: remove notion of config "type") Eric Sandeen
2018-06-14 15:43 ` [PATCH 3/2] mkfs: manpage fixups in config file section Eric Sandeen
2018-06-14 16:43 ` Darrick J. Wong
2018-06-14 16:20 ` [PATCH 4/2] mkfs: add -c option to the --help screen Darrick J. Wong
2018-06-14 16:34 ` Eric Sandeen
2018-06-14 16:49 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614164136.GD6825@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).