From: Carlos Maiolino <cmaiolino@redhat.com>
To: Ilya Pronin <ipronin@twitter.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: Reading/changing projid of a symlink
Date: Fri, 15 Jun 2018 09:08:29 +0200 [thread overview]
Message-ID: <20180615070829.m5ligybzlods4l5r@odin.usersys.redhat.com> (raw)
In-Reply-To: <CA+Xn3kzsrqjNH2yXdtfsRuiCBfvX2GSWOW2SaLPL4h1PmQsGBg@mail.gmail.com>
On Thu, Jun 14, 2018 at 05:14:34PM -0700, Ilya Pronin wrote:
> Thanks everyone for the answers!
>
> On Wed, Jun 13, 2018 at 2:40 AM, Carlos Maiolino <cmaiolino@redhat.com> wrote:
> > The symlink's project id, will always be related to the project id of its parent
> > directory.
> >
> > At the end, Project quota, is a way to create a directory tree based quota,
> > where all inodes corresponding to a single project id, should be under the same
> > subtree. If you are creating a new subtree, under an already existing project
> > id, IMHO, the right approach would be to remove the project id from the old
> > directory tree, and add it to the new tree, and use user/group quotas for any
> > quota accounting that should be done filesystem-wide (instead of directory tree
> > wise).
>
> It's a bit weird though that a symlink can inherit project ID from its
> parent directory,
Well, yes, a symlink occupy an inode, and so, we need to account for it, in case
for example, you limit inode creation in the project id.
> but then cannot get rid of it :) And thus doesn't
> allow to completely remove the project ID from the directory tree it's
> in.
Once you move the symlink out of the project subtree, the project id will be
removed or updated to the new project id (in case its new place belongs to
another project id).
As I said before, IMHO, I believe the way you are using project quotas is wrong.
Project quotas is supposed to be used on a sub-tree based granularity, not on a
file based granularity. But again, that's just my opinion.
>
> --
> Ilya Pronin
--
Carlos
next prev parent reply other threads:[~2018-06-15 7:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 0:26 Reading/changing projid of a symlink Ilya Pronin
2018-06-12 14:36 ` Carlos Maiolino
2018-06-12 22:17 ` Ilya Pronin
2018-06-13 6:23 ` Christoph Hellwig
2018-06-13 14:22 ` Eric Sandeen
2018-06-13 9:40 ` Carlos Maiolino
2018-06-15 0:14 ` Ilya Pronin
2018-06-15 7:08 ` Carlos Maiolino [this message]
2018-06-15 7:12 ` Christoph Hellwig
2018-06-15 8:57 ` Carlos Maiolino
2018-06-15 9:00 ` Christoph Hellwig
2018-06-14 2:31 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180615070829.m5ligybzlods4l5r@odin.usersys.redhat.com \
--to=cmaiolino@redhat.com \
--cc=ipronin@twitter.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).