[PATCH 0/2] xfs: symlink and inode writeback issues

[Dave Chinner <david@fromorbit.com>]

Hi folks,

The first patch is the replacement fix for the symlink verification
problem I originally posted as "xfs: symlinks can be zero length
during log recovery" a few days ago. This caused the symlink data
fork verifier to fire during inode writeback, and in tracking that
down it became clear that zero length symlinks are not valid,
despite repeated comments in the code that "they can happen". This
new patch prevents zero length symlink inodes from ever getting to
disk, and prevents transient states in memory where the symlink data
fork is zero length.

The second patch is a fix for a problem discovered by the original
symlink verifier patch - when it fired in inode writeback it would
do a double flush lock release on the inode, triggering an assert.
nothing good can come from that, so I tracked down the dark, dusty
origins of the crappy error handling in the inode writeback code and
fixed it, too.

Comments, thoughts?

Cheers,

Dave.