linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: linux-xfs@vger.kernel.org
Cc: Christoph Hellwig <hch@infradead.org>
Subject: [PATCH 0/2] xfs_buf_submit[_wait]() cleanups
Date: Mon, 18 Jun 2018 10:52:42 -0400	[thread overview]
Message-ID: <20180618145244.30393-1-bfoster@redhat.com> (raw)

These are just a couple cleanups for buffer I/O submission based on
suggestions from Christoph. This applies on top of the previously posted
delwri queue fix [1].

The combination of both slightly circuitously condenses the buf
submission path back into a single helper, but we end up in the same
place either way. I'm sending this separately because review of the
value of this interface refactor is independent of the internal refactor
required to implement the aforementioned bug fix.

Thoughts, reviews, flames appreciated.

[1] https://marc.info/?l=linux-xfs&m=152908593803756&w=2

Brian

Brian Foster (2):
  xfs: combine [a]sync buffer submission apis
  xfs: kill __xfs_buf_submit_common()

 fs/xfs/xfs_buf.c         | 125 +++++++++++++--------------------------
 fs/xfs/xfs_buf.h         |  10 +++-
 fs/xfs/xfs_log_recover.c |   4 +-
 3 files changed, 52 insertions(+), 87 deletions(-)

-- 
2.17.1


             reply	other threads:[~2018-06-18 14:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-18 14:52 Brian Foster [this message]
2018-06-18 14:52 ` [PATCH 1/2] xfs: combine [a]sync buffer submission apis Brian Foster
2018-06-19  5:25   ` Darrick J. Wong
2018-06-20  7:41   ` Christoph Hellwig
2018-06-18 14:52 ` [PATCH 2/2] xfs: kill __xfs_buf_submit_common() Brian Foster
2018-06-19  5:25   ` Darrick J. Wong
2018-06-20  7:42   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180618145244.30393-1-bfoster@redhat.com \
    --to=bfoster@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).