From: Dave Chinner <david@fromorbit.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: XFS: Assertion failed: !rwsem_is_locked(&inode->i_rwsem)
Date: Tue, 19 Jun 2018 12:32:46 +1000 [thread overview]
Message-ID: <20180619023246.GG19934@dastard> (raw)
In-Reply-To: <20180619021746.GA6652@linux.intel.com>
On Mon, Jun 18, 2018 at 08:17:46PM -0600, Ross Zwisler wrote:
> During some xfstest runs on next-20180615 I hit the following with DAX +
> generic/388:
>
> ================================================
> WARNING: lock held when returning to user space!
> 4.17.0-next-20180615-00001-gf09d99951966 #2 Not tainted
> ------------------------------------------------
> fsstress/6598 is leaving the kernel with locks still held!
> 2 locks held by fsstress/6598:
> #0: 00000000d8f89e14 (&sb->s_type->i_mutex_key#13){++++}, at: xfs_ilock+0x211/0x310
> #1: 000000005cc93137 (&(&ip->i_mmaplock)->mr_lock){++++}, at: xfs_ilock+0x1eb/0x310
What errors occurred before this? generic/388 is testing all sorts
of error paths by randomly shutting down the filesystem, so it'e
entirely possible that we've leaked those locks (XFS_IOLOCK and
XFS_MMAPLOCK) on some rarely travelled error path. The prior errors
might help identify that path.
> XFS: Assertion failed: !rwsem_is_locked(&inode->i_rwsem), file: fs/xfs/xfs_super.c, line: 966
As this is just a follow on issue at unmount where we expect the
inode to be unlocked before tearing it down - it's just a messenger,
not the smoking gun...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-06-19 2:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 2:17 XFS: Assertion failed: !rwsem_is_locked(&inode->i_rwsem) Ross Zwisler
2018-06-19 2:32 ` Dave Chinner [this message]
2018-06-19 16:44 ` Ross Zwisler
2018-06-19 23:29 ` Dave Chinner
2018-07-09 22:04 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180619023246.GG19934@dastard \
--to=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).