Re: [PATCH v2] mkfs: add mkfs config version specifier for the config file

Dave Chinner
2018-06-20T23:18:52Z

On Tue, Jun 19, 2018 at 10:57:10PM +0200, Luis R. Rodriguez wrote:
> On Tue, Jun 19, 2018 at 02:53:28PM -0500, Eric Sandeen wrote:
> > Soo....
> >
> > I'm really on the fence about versioning at all, because we have yet to
> > identify any concrete scenario in which we'd need to bump the version;
> > we haven't even defined what exactly the "version" implies.
>
> Right.
>
> > So unless anyone has a concrete example of how a version would be needed,
> > functional, reliably-parsed, and well-defined I'm inclined to leave this out.
>
> Dave asked for it, so I would imagine he could make a better case for it.

I ask for things so that people think about the problem, not
necessarily because I want something to be done. Please don't
conflate "Dave says X" with "we must implement X" because I am often
wrong and/or playing the Devil's Advocate role.

I try to look outside the box for potential issues, so if I see a
potential issue I'll say /something/ just to get people to discuss
that aspect of the problem and come up with a reasonable solution. I
don't have the time to solve every problem we have, I don't
/want/ to solve every problem, but I want to make sure we solve
the problems we have in the right way the first time.

In reality, I don't care either way if we have a version symbol in
the config file, and if it is decided that it is a good thing how it
will be implemented. What I care about is that we've thought about
supporting config files over their entire lifetime, not just
considered what is needed in the near term to solve the immediate
problem.

IOWs, my comments about treating a config file like any other
long term persistent structure were intended to shift the focus of
the discussion from implementation minutae to the bigger, long term
picture details that needed to be thrashed out. Work out the big
picture first, the small details will fall naturally from that...

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com