Re: [PATCH 2/2] xfstests: Test root inode parent pointer repairing

[Dave Chinner <david@fromorbit.com>]

On Mon, Jun 18, 2018 at 02:44:33PM -0300, Marco Benatto wrote:
> Recently we found out xfs_repair were not repairing
> root inode parent pointer when root inode is on short-form
> and parent points to an invalid inode number (refer to:
> "xfs_repair: Fix root inode's parent when it's bogus for sf
> directory" on xfs-devel list).
> 
> This test checks if xfs_repair successfully repair the
> filesystem in the scenario mentioned before.
> 
> Signed-off-by: Marco Benatto <mbenatto@redhat.com>
> ---
>  tests/xfs/450     | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  tests/xfs/450.out |  1 +
>  tests/xfs/group   |  1 +
>  3 files changed, 55 insertions(+)
>  create mode 100755 tests/xfs/450
>  create mode 100644 tests/xfs/450.out
> 
> diff --git a/tests/xfs/450 b/tests/xfs/450
> new file mode 100755
> index 0000000..dc7f244
> --- /dev/null
> +++ b/tests/xfs/450
> @@ -0,0 +1,53 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2018 Red Hat Inc.  All Rights Reserved.
> +#
> +# FS QA Test 450
> +#
> +# Make sure xfs_repair can repair root inode parent's pointer
> +# when it contains a bogus ino when it's using shot form directory
> +#
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +
> +status=1	# failure is the default!
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +
> +# remove previous $seqres.full before test
> +rm -f $seqres.full
> +
> +# real QA test starts here
> +
> +# Modify as appropriate.
> +_supported_fs xfs
> +_supported_os Linux
> +_require_scratch
> +
> +
> +_scratch_mkfs >> /dev/null 2>&1
> +
> +rootino=$(_scratch_xfs_get_metadata_field 'rootino' 'sb 0')
> +
> +prefix=$(_scratch_get_sfdir_prefix ${rootino} || \
> +		_fail "Cannot determine sfdir prefix")
> +
> +
> +# Corrupt root inode parent pointer
> +_scratch_xfs_set_metadata_field "${prefix}.hdr.parent.i4" 0 "inode ${rootino}"\
> +								>> $seqres.full
> +
> +_scratch_xfs_repair >> $seqres.full 2>&1
> +
> +_scratch_xfs_repair -n >> $seqres.full 2>&1
> +
> +if [ $? -eq 1 ]
> +then
> +	_fail "xfs_repair failed to repair filesystem"
> +fi

Isn't this last "filesystem is not corrupt" check run by the harness
via _check_scratch_fs()?

(Also, "if [ .. ]; then" is the preferred fstests style)

> +
> +echo "OK"

There's no test output, so the normal thing to do is this after
setting up the test:

echo "Silence is golden"

We do that early on so that when something goes wrong the bad output
file immediately tells you that no output was expected.

> @@ -447,3 +447,4 @@
>  447 auto mount
>  448 auto quick fuzzers
>  449 auto quick
> +450 auto quick

also  the metadata and repair groups should be added here.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com