From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs_bmap: don't reject -e
Date: Thu, 21 Jun 2018 12:47:38 -0700 [thread overview]
Message-ID: <20180621194738.GF4838@magnolia> (raw)
In-Reply-To: <9abcfd43-7d1f-bc8f-299b-0d015c4f2241@sandeen.net>
On Thu, Jun 21, 2018 at 02:32:44PM -0500, Eric Sandeen wrote:
> On 6/21/18 1:49 PM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > The xfs_io bmap command has an -e switch that prints delalloc extents
> > without fsync'ing the file first. The xfs_bmap manpage says it'll pass
> > -e through, but it doesn't. Fix the script and fix the weird manpage
> > discrepancy where it doesn't list -e in the available options but
> > discusses it anyway.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> need to fix it all up for "-c" as well, right?
The cow fork bmap only works if CONFIG_XFS_DEBUG=y (per review comment
when reflink was being developed) so I never bothered wiring it up from
xfs_bmap.sh, only xfs_io.
> and I think:
>
> Fixes: 7536ce44f6 ("xfs_io: bmap should support querying CoW fork, shared blocks")
Ok.
--D
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-06-21 19:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 18:49 [PATCH] xfs_bmap: don't reject -e Darrick J. Wong
2018-06-21 19:32 ` Eric Sandeen
2018-06-21 19:47 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180621194738.GF4838@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox