From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, zlang@redhat.com,
Christoph Hellwig <hch@infradead.org>,
Allison Henderson <allison.henderson@oracle.com>
Subject: Re: [PATCH v2 4/8] xfs: don't allow insert-range to shift extents past the maximum offset
Date: Fri, 22 Jun 2018 23:47:02 -0700 [thread overview]
Message-ID: <20180623064702.GA9497@infradead.org> (raw)
In-Reply-To: <20180622212104.GT4838@magnolia>
On Fri, Jun 22, 2018 at 02:21:04PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Zorro Lang reports that generic/485 blows an assert on a filesystem with
> 512 byte blocks. The test tries to fallocate a post-eof extent at the
> maximum file size and calls insert range to shift the extents right by
> two blocks. On a 512b block filesystem this causes startoff to overflow
> the 54-bit startoff field, leading to the assert.
>
> Therefore, always check the rightmost extent to see if it would overflow
> prior to invoking the insert range machinery.
>
> Reported-by: zlang@redhat.com
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=200137
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2018-06-23 6:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 18:31 [PATCH 0/8] xfs-4.18: various fixes Darrick J. Wong
2018-06-21 18:31 ` [PATCH 1/8] xfs: allow empty transactions while frozen Darrick J. Wong
2018-06-22 6:18 ` Allison Henderson
2018-06-22 6:31 ` Christoph Hellwig
2018-06-21 18:31 ` [PATCH 2/8] xfs: fix fdblocks accounting w/ RMAPBT per-AG reservation Darrick J. Wong
2018-06-22 6:21 ` Allison Henderson
2018-06-21 18:31 ` [PATCH 3/8] xfs: don't trip over negative free space in xfs_reserve_blocks Darrick J. Wong
2018-06-22 6:31 ` Christoph Hellwig
2018-06-22 6:32 ` Allison Henderson
2018-06-21 18:31 ` [PATCH 4/8] xfs: don't allow insert-range to shift extents past the maximum offset Darrick J. Wong
2018-06-22 6:33 ` Allison Henderson
2018-06-22 6:39 ` Christoph Hellwig
2018-06-22 6:47 ` Darrick J. Wong
2018-06-22 21:21 ` [PATCH v2 " Darrick J. Wong
2018-06-23 6:47 ` Christoph Hellwig [this message]
2018-06-21 18:31 ` [PATCH 5/8] xfs: recheck reflink state after grabbing ILOCK_SHARED for a write Darrick J. Wong
2018-06-22 6:40 ` Christoph Hellwig
2018-06-21 18:31 ` [PATCH 6/8] xfs: fix uninitialized field in rtbitmap fsmap backend Darrick J. Wong
2018-06-22 6:37 ` Allison Henderson
2018-06-22 6:41 ` Christoph Hellwig
2018-06-22 6:47 ` Darrick J. Wong
2018-06-22 21:22 ` [PATCH v2 " Darrick J. Wong
2018-06-23 6:47 ` Christoph Hellwig
2018-06-21 18:31 ` [PATCH 7/8] xfs: fix off-by-one error in xfs_rtalloc_query_range Darrick J. Wong
2018-06-22 6:41 ` Christoph Hellwig
2018-06-22 6:41 ` Allison Henderson
2018-06-21 18:31 ` [PATCH 8/8] xfs: ensure post-EOF zeroing happens after zeroing part of a file Darrick J. Wong
2018-06-22 6:29 ` Christoph Hellwig
2018-06-22 6:49 ` Darrick J. Wong
2018-06-22 6:42 ` Allison Henderson
2018-06-22 6:21 ` [PATCH 9/8] xfs: check leaf attribute block freemap in verifier Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180623064702.GA9497@infradead.org \
--to=hch@infradead.org \
--cc=allison.henderson@oracle.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).