From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2130.oracle.com ([156.151.31.86]:49272 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753119AbeGDAzh (ORCPT ); Tue, 3 Jul 2018 20:55:37 -0400 Date: Tue, 3 Jul 2018 17:55:22 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH 22/25] xfs: use ->t_firstblock in reflink cow block cancel Message-ID: <20180704005522.GV32415@magnolia> References: <20180703172319.24509-1-bfoster@redhat.com> <20180703172319.24509-23-bfoster@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180703172319.24509-23-bfoster@redhat.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Brian Foster Cc: linux-xfs@vger.kernel.org On Tue, Jul 03, 2018 at 01:23:16PM -0400, Brian Foster wrote: > Signed-off-by: Brian Foster Looks ok, Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/xfs_reflink.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c > index cf6080d42273..d509bd7fa822 100644 > --- a/fs/xfs/xfs_reflink.c > +++ b/fs/xfs/xfs_reflink.c > @@ -546,7 +546,6 @@ xfs_reflink_cancel_cow_blocks( > struct xfs_ifork *ifp = XFS_IFORK_PTR(ip, XFS_COW_FORK); > struct xfs_bmbt_irec got, del; > struct xfs_iext_cursor icur; > - xfs_fsblock_t firstfsb; > struct xfs_defer_ops dfops; > struct xfs_defer_ops *odfops = (*tpp)->t_dfops; > int error = 0; > @@ -575,7 +574,7 @@ xfs_reflink_cancel_cow_blocks( > if (error) > break; > } else if (del.br_state == XFS_EXT_UNWRITTEN || cancel_real) { > - xfs_defer_init(*tpp, &dfops, &firstfsb); > + xfs_defer_init(*tpp, &dfops, &(*tpp)->t_firstblock); > > /* Free the CoW orphan record. */ > error = xfs_refcount_free_cow_extent(ip->i_mount, > -- > 2.17.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html