public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Zorro Lang <zlang@redhat.com>
To: fstests@vger.kernel.org
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH] common/xfs: remove bad xfs_repair -t option
Date: Tue, 10 Jul 2018 17:41:29 +0800	[thread overview]
Message-ID: <20180710094129.1052-1-zlang@redhat.com> (raw)

The xfs_repair "-t" option shouldn't be used alone. An interval must
follow the -t option, or xfs_repair will report errors. And only
modify reporting interval is useless, if we don't enable ag_stride.

Signed-off-by: Zorro Lang <zlang@redhat.com>
---

Hi,

I don't know why we must need the -t option for xfs_repair, I can't
find any description to explain it. But I can find an explanation
about why we use "-t" for _xfs_check.

  # xfs_check runs out of memory on large files, so even providing the test
  # option (-t) to avoid indexing the free space trees doesn't make it pass on
  # large filesystems. Avoid it.

The -t option for xfs_repair is totally different with it for
xfs_check, maybe -m option is more useful if we think about the
memory size.

And the -t option need to work with -o ag_stride together. I'd like
to remove the "-t" option directly, due to I really don't know why
we need it, or how to give it a proper number.

If the original author knows why we need it, and can give me some
suggestions, please help.

Thanks,
Zorro

 common/xfs | 1 -
 1 file changed, 1 deletion(-)

diff --git a/common/xfs b/common/xfs
index ecf54bbf..61a3c2d9 100644
--- a/common/xfs
+++ b/common/xfs
@@ -193,7 +193,6 @@ _scratch_xfs_repair()
 		SCRATCH_OPTIONS="-l$SCRATCH_LOGDEV"
 	[ "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_RTDEV" ] && \
 		SCRATCH_OPTIONS=$SCRATCH_OPTIONS" -r$SCRATCH_RTDEV"
-	[ "$LARGE_SCRATCH_DEV" = yes ] && SCRATCH_OPTIONS=$SCRATCH_OPTIONS" -t"
 	$XFS_REPAIR_PROG $SCRATCH_OPTIONS $* $SCRATCH_DEV
 }
 
-- 
2.14.4


             reply	other threads:[~2018-07-10  9:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-10  9:41 Zorro Lang [this message]
2018-07-10 14:43 ` [PATCH] common/xfs: remove bad xfs_repair -t option Darrick J. Wong
2018-07-10 14:43 ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180710094129.1052-1-zlang@redhat.com \
    --to=zlang@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox