From: Bill O'Donnell <billodo@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH] libxfs: add more bounds checking to sb sanity checks
Date: Fri, 13 Jul 2018 08:10:03 -0500 [thread overview]
Message-ID: <20180713131003.31121-1-billodo@redhat.com> (raw)
Current sb verifier doesn't check bounds on sb_fdblocks and sb_ifree.
Add sanity checks for these parameters.
Signed-off-by: Bill O'Donnell <billodo@redhat.com>
---
fs/xfs/libxfs/xfs_sb.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c
index 350119eeaecb..cdede769ab88 100644
--- a/fs/xfs/libxfs/xfs_sb.c
+++ b/fs/xfs/libxfs/xfs_sb.c
@@ -261,7 +261,9 @@ xfs_mount_validate_sb(
sbp->sb_dblocks == 0 ||
sbp->sb_dblocks > XFS_MAX_DBLOCKS(sbp) ||
sbp->sb_dblocks < XFS_MIN_DBLOCKS(sbp) ||
- sbp->sb_shared_vn != 0)) {
+ sbp->sb_shared_vn != 0 ||
+ sbp->sb_fdblocks > sbp->sb_dblocks ||
+ sbp->sb_ifree > sbp->sb_icount)) {
xfs_notice(mp, "SB sanity check failed");
return -EFSCORRUPTED;
}
--
2.17.1
next reply other threads:[~2018-07-13 13:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 13:10 Bill O'Donnell [this message]
2018-07-13 16:41 ` [PATCH] libxfs: add more bounds checking to sb sanity checks Darrick J. Wong
2018-07-13 20:06 ` Bill O'Donnell
2018-07-13 23:43 ` Dave Chinner
2018-07-17 17:13 ` Darrick J. Wong
2018-07-16 19:26 ` [PATCH v2] " Bill O'Donnell
2018-07-17 9:17 ` Carlos Maiolino
2018-07-17 17:06 ` Darrick J. Wong
2018-07-17 17:17 ` Bill O'Donnell
2018-07-17 19:12 ` Bill O'Donnell
2018-07-17 20:33 ` Darrick J. Wong
2018-07-17 23:26 ` Dave Chinner
2018-07-18 20:07 ` Bill O'Donnell
2018-07-25 21:33 ` [PATCH v3] " Bill O'Donnell
2018-07-25 21:47 ` Darrick J. Wong
2018-07-25 21:58 ` Bill O'Donnell
2018-07-25 22:48 ` Eric Sandeen
2018-07-25 22:55 ` Darrick J. Wong
2018-07-26 16:40 ` [PATCH v4] " Bill O'Donnell
2018-07-26 17:07 ` Darrick J. Wong
2018-07-26 17:19 ` Bill O'Donnell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180713131003.31121-1-billodo@redhat.com \
--to=billodo@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).