linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Carlos Maiolino <cmaiolino@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Eric Sandeen <sandeen@sandeen.net>,
	Chris Murphy <lists@colorremedies.com>,
	xfs list <linux-xfs@vger.kernel.org>
Subject: Re: filefrag and reflink
Date: Thu, 19 Jul 2018 13:45:14 +0200	[thread overview]
Message-ID: <20180719114514.xwfxoy4nco77lacs@odin.usersys.redhat.com> (raw)
In-Reply-To: <20180718204715.GB4813@magnolia>

> > zeros, while a cp --reflink will create a sparse file, though?
> 
> Well see therein lies the problem.  The documentation for cp states:
> 
> "When --reflink[=always] is specified, perform a lightweight copy, where
> the data blocks are copied only when modified."
> 
> The lightest weight copy for a bunch of zeroes is a hole.  That's the
> interpretation I went with. :)
> 
> OTOH the "copied only when modified" language does sort of imply that
> you'd share the unwritten extents and then COW them, but that involves
> adding more machinery to _iomap_begin to copy-write over zeroes,
> which seems pointless and would involve a format change since old
> kernels wouldn't know to check for shared unwritten extents...
> 
> ...and if your worry is about being able to write to tmp3 without
> hitting ENOSPC then you'll have to fallocate + funshare the file
> separately anyway.

/me should read the whole thread before replying to earlier messages :P

> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Carlos

  parent reply	other threads:[~2018-07-19 12:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-18 18:41 filefrag and reflink Chris Murphy
2018-07-18 19:59 ` Darrick J. Wong
2018-07-18 20:27   ` Eric Sandeen
2018-07-18 20:47     ` Darrick J. Wong
2018-07-18 21:07       ` Eric Sandeen
2018-07-19  0:09         ` Darrick J. Wong
2018-07-19 11:45       ` Carlos Maiolino [this message]
2018-07-19 11:34     ` Carlos Maiolino
2018-07-19 14:39       ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180719114514.xwfxoy4nco77lacs@odin.usersys.redhat.com \
    --to=cmaiolino@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=lists@colorremedies.com \
    --cc=sandeen@sandeen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).