Query about the handling of a bug reported before

Query about the handling of a bug reported before

[Xu, Wen]

Hi XFS developers,

I wonder if this bug

https://bugzilla.kernel.org/show_bug.cgi?id=200127

has already been resolved by any patch.

Thanks,
Wen

Re: Query about the handling of a bug reported before

[Brian Foster]

On Sun, Jul 22, 2018 at 06:30:03AM +0000, Xu, Wen wrote:
> Hi XFS developers,
> 
> I wonder if this bug
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=200127
> 
> has already been resolved by any patch.
> 

It looks like you're on a kernel that already has the agfl reset
mechanism. I'm not aware of anything else in that area off the top of my
head, but FWIW, I don't see the KASAN error with a quick check on a
KASAN-enabled latest for-next (4.18.0-rc4) kernel. Have you given that a
try?

Brian

> Thanks,
> Wen
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Query about the handling of a bug reported before

[Xu, Wen]

Hi Brian,

Yeah I tested it which is fixed in latest kernel. I just wonder if there is a specific patch
for this.

Thanks,
Wen

> On Jul 23, 2018, at 8:32 AM, Brian Foster <bfoster@redhat.com> wrote:
> 
> On Sun, Jul 22, 2018 at 06:30:03AM +0000, Xu, Wen wrote:
>> Hi XFS developers,
>> 
>> I wonder if this bug
>> 
>> https://bugzilla.kernel.org/show_bug.cgi?id=200127
>> 
>> has already been resolved by any patch.
>> 
> 
> It looks like you're on a kernel that already has the agfl reset
> mechanism. I'm not aware of anything else in that area off the top of my
> head, but FWIW, I don't see the KASAN error with a quick check on a
> KASAN-enabled latest for-next (4.18.0-rc4) kernel. Have you given that a
> try?
> 
> Brian
> 
>> Thanks,
>> Wen
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Query about the handling of a bug reported before

[Dave Chinner]

On Mon, Jul 23, 2018 at 02:27:02PM +0000, Xu, Wen wrote:
> Hi Brian,
> 
> Yeah I tested it which is fixed in latest kernel. I just wonder if there is a specific patch
> for this.

The code was fixed as a result of committing the huge patch series
that removed bufferheads from the XFS IO path.  i.e. the bug went
away because of other changes that addressed the root cause, not
because we committed a change that specifically fixed the bug. Most
likely it was this commit in the middle of the series to remove
bufferhead dependencies in xfs_aops_discard_page() that solved the
problem.

e2ac836307e3 ("xfs: simplify xfs_bmap_punch_delalloc_range")

-Dave.

-- 
Dave Chinner
david@fromorbit.com

Re: Query about the handling of a bug reported before

[Xu, Wen]

Got it, thanks.

> On Jul 24, 2018, at 6:47 PM, Dave Chinner <david@fromorbit.com> wrote:
> 
> On Mon, Jul 23, 2018 at 02:27:02PM +0000, Xu, Wen wrote:
>> Hi Brian,
>> 
>> Yeah I tested it which is fixed in latest kernel. I just wonder if there is a specific patch
>> for this.
> 
> The code was fixed as a result of committing the huge patch series
> that removed bufferheads from the XFS IO path.  i.e. the bug went
> away because of other changes that addressed the root cause, not
> because we committed a change that specifically fixed the bug. Most
> likely it was this commit in the middle of the series to remove
> bufferhead dependencies in xfs_aops_discard_page() that solved the
> problem.
> 
> e2ac836307e3 ("xfs: simplify xfs_bmap_punch_delalloc_range")
> 
> -Dave.
> 
> -- 
> Dave Chinner
> david@fromorbit.com