Re: [PATCH 1/2] xfs: kill IHOLD

[Carlos Maiolino <cmaiolino@redhat.com>]

On Tue, Jul 24, 2018 at 06:14:52PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Nobody uses this macro, get rid of it.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>  fs/xfs/xfs_inode.h |    7 -------
>  1 file changed, 7 deletions(-)
> 
> 
> diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h
> index 2ed63a49e890..8e18bc0fedd0 100644
> --- a/fs/xfs/xfs_inode.h
> +++ b/fs/xfs/xfs_inode.h
> @@ -484,13 +484,6 @@ static inline void xfs_setup_existing_inode(struct xfs_inode *ip)
>  	xfs_finish_inode_setup(ip);
>  }
>  
> -#define IHOLD(ip) \
> -do { \
> -	ASSERT(atomic_read(&VFS_I(ip)->i_count) > 0) ; \
> -	ihold(VFS_I(ip)); \
> -	trace_xfs_ihold(ip, _THIS_IP_); \
> -} while (0)
> -

And looks like trace_xfs_ihold is gone for almost two years...

Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

>  #define IRELE(ip) \
>  do { \
>  	trace_xfs_irele(ip, _THIS_IP_); \
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Carlos