Re: [PATCH 2/2] xfs: clean up IRELE/iput callsites

["Darrick J. Wong" <darrick.wong@oracle.com>]

On Wed, Jul 25, 2018 at 06:00:28AM +0200, Carlos Maiolino wrote:
> On Tue, Jul 24, 2018 at 06:14:58PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> > 
> > Replace the IRELE macro with a proper function so that we can do proper
> > typechecking and so that we can stop open-coding iput in scrub, which
> > means that we'll be able to ftrace inode lifetimes going through scrub
> > correctly.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> >  }
> > +
> > +/* Release an inode. */
> > +void
> > +xfs_irele(
> > +	struct xfs_inode	*ip)
> > +{
> > +	trace_xfs_irele(ip, _RET_IP_);
> > +	iput(VFS_I(ip));
> > +}
> 
> I think this still shows the callers of xfs_irele() in the trace right? Assuming
> I'm right here:

Correct, this will point back to the return address of the call stack,
which should be the next line in the source code.

--D

> Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> 
> 
> > diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h
> > index 8e18bc0fedd0..fa05f8126b00 100644
> > --- a/fs/xfs/xfs_inode.h
> > +++ b/fs/xfs/xfs_inode.h
> > @@ -484,11 +484,7 @@ static inline void xfs_setup_existing_inode(struct xfs_inode *ip)
> >  	xfs_finish_inode_setup(ip);
> >  }
> >  
> > -#define IRELE(ip) \
> > -do { \
> > -	trace_xfs_irele(ip, _THIS_IP_); \
> > -	iput(VFS_I(ip)); \
> > -} while (0)
> > +void xfs_irele(struct xfs_inode *ip);
> >  
> >  
> 
> -- 
> Carlos
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html