linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zorro Lang <zlang@redhat.com>
To: fstests@vger.kernel.org
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH] xfs/288: use -d option of xfs_db write command for v5 XFS
Date: Sun, 29 Jul 2018 22:20:53 +0800	[thread overview]
Message-ID: <20180729142053.4240-1-zlang@redhat.com> (raw)

The commit b3cf8b72334fd35ef961869506e5a72ab398bc82 update xfs/288
to support v5 filesystem testing. That commit thought xfs_db write
command can work well with -d option on V5 XFS. But the truth is
the case doesn't use that option.

So turn to use _scratch_xfs_set_metadata_field, it will help to use
proper options for xfs_db write command.

Signed-off-by: Zorro Lang <zlang@redhat.com>
---

Hi,

Missing '-d' option is a case issue. But from this issue, we found another
bug of xfsprogs. On current upstream, this case will test pass on v5 XFS,
even there's not '-d' option for write command.

That's a bug, we'll fix it later. For now, I'd like to fix this case
issue at first.

Thanks,
Zorro

 tests/xfs/288 | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/xfs/288 b/tests/xfs/288
index bccdb6fc..f4165b6c 100755
--- a/tests/xfs/288
+++ b/tests/xfs/288
@@ -56,9 +56,8 @@ $SETFATTR_PROG -n "user.testattr${seq}" \
 
 _scratch_unmount
 # manually corrupt the XFS, by set the header count of attr to 0
-_scratch_xfs_db -x -c "inode $inum" \
-		   -c "ablock 0" \
-		   -c "write hdr.count 0" >> $seqres.full
+_scratch_xfs_set_metadata_field "hdr.count" "0" \
+				"inode $inum" "ablock 0" >> $seqres.full
 
 # make sure xfs_repair can find above corruption. If it can't, that
 # means we need to fix this bug on current xfs_repair
-- 
2.14.4


             reply	other threads:[~2018-07-29 15:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-29 14:20 Zorro Lang [this message]
2018-07-29 15:56 ` [PATCH] xfs/288: use -d option of xfs_db write command for v5 XFS Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180729142053.4240-1-zlang@redhat.com \
    --to=zlang@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).