From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] misc: remove COPYING from doc/ Makefile
Date: Mon, 30 Jul 2018 20:45:56 -0700 [thread overview]
Message-ID: <20180731034556.GT30972@magnolia> (raw)
In-Reply-To: <e4d64c9b-5a1a-54b5-8b69-463738c95307@redhat.com>
On Mon, Jul 30, 2018 at 10:41:54PM -0500, Eric Sandeen wrote:
> COPYING is gone now, so make doc-install breaks.
>
> Fixes: 959ef98 ("xfsprogs: convert to SPDX license tags")
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
>
> diff --git a/doc/Makefile b/doc/Makefile
> index 8b870dc..83dfa38 100644
> --- a/doc/Makefile
> +++ b/doc/Makefile
> @@ -5,7 +5,7 @@
> TOPDIR = ..
> include $(TOPDIR)/include/builddefs
>
> -LSRCFILES = INSTALL CHANGES COPYING CREDITS sparse.txt
> +LSRCFILES = INSTALL CHANGES CREDITS sparse.txt
> LDIRT = *.gz
>
> default: CHANGES.gz
> @@ -21,8 +21,6 @@ install: default
> $(INSTALL) -m 644 CHANGES.gz CREDITS $(PKG_DOC_DIR)
> ifeq ($(PKG_DISTRIBUTION), debian)
> $(INSTALL) -S CHANGES.gz $(PKG_DOC_DIR)/changelog.gz
> -else
> - $(INSTALL) -m 644 COPYING $(PKG_DOC_DIR)
> endif
>
> install-dev:
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-07-31 5:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 3:41 [PATCH] misc: remove COPYING from doc/ Makefile Eric Sandeen
2018-07-31 3:45 ` Darrick J. Wong [this message]
2018-07-31 7:43 ` Christoph Hellwig
2018-07-31 8:06 ` Dave Chinner
2018-07-31 8:08 ` Christoph Hellwig
2018-07-31 15:36 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731034556.GT30972@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).