From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Sandeen <sandeen@redhat.com>, linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] misc: remove COPYING from doc/ Makefile
Date: Tue, 31 Jul 2018 18:06:46 +1000 [thread overview]
Message-ID: <20180731080646.GF2234@dastard> (raw)
In-Reply-To: <20180731074313.GA19990@infradead.org>
On Tue, Jul 31, 2018 at 12:43:13AM -0700, Christoph Hellwig wrote:
> On Mon, Jul 30, 2018 at 10:41:54PM -0500, Eric Sandeen wrote:
> > COPYING is gone now, so make doc-install breaks.
> >
> > Fixes: 959ef98 ("xfsprogs: convert to SPDX license tags")
> >
> > Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> The patch itself looks good, but I think we have a deeper problem,
> in that there is no actual license information anywhere in xfsprogs now.
>
> We need to fix that up similar to the LICENSES/ directory in the kernel.
> SPDX tags are good and nice, but without an explanation what they mean
> in the same source tree they are useless.
Sorry, what? I added that as part of my spdx conversion patch. That
patch also removed the COPYING file.
How did these changes get merged? I sent a pull request to convert
everything in xfsprogs and that had all the correct conversions and
documentation in it. here's the pull request:
https://marc.info/?l=linux-xfs&m=152948738523911&w=2
and you can see from the diffstat it did all this stuff...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-07-31 9:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 3:41 [PATCH] misc: remove COPYING from doc/ Makefile Eric Sandeen
2018-07-31 3:45 ` Darrick J. Wong
2018-07-31 7:43 ` Christoph Hellwig
2018-07-31 8:06 ` Dave Chinner [this message]
2018-07-31 8:08 ` Christoph Hellwig
2018-07-31 15:36 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731080646.GF2234@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).