linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Chris Murphy <lists@colorremedies.com>
Cc: xfs list <linux-xfs@vger.kernel.org>
Subject: Re: agcount 33 by default for a single HDD?
Date: Wed, 1 Aug 2018 14:12:04 +1000	[thread overview]
Message-ID: <20180801041204.GH2234@dastard> (raw)
In-Reply-To: <CAJCQCtQpeQ_z9gMHhnhSvzJed4HfT=pxpORTTNjJQUogvVjLgA@mail.gmail.com>

On Tue, Jul 31, 2018 at 07:32:50PM -0600, Chris Murphy wrote:
> This seems suboptimal.

It's actually a very useful optimisation to make on thin devices.

> Basically this is a 750G thin volume. I don't
> have a plain partition on a device handy to try this out but I'm
> pretty certain the default is 4 AG's in that case, so I'm confused why
> by default 33 AGs are created on a thin volume. The LVM volume group
> is on a dmcrypt PV.

It's a thin volume, therefore it advertises an optimal IO size and
alignment setting (i.e. the thin volume allocation chunk size).
Hence mkfs.xfs treats it as a "multi-disk device" and sets up
alignment and AG count appropriately.

This is actually the right optimisation to make for sparse devices -
more AGs increase filesystem concurrency but we normally restrict it
on single spindles because each AG adds more seeks into typical
workloads and slows them down. However, the thin volume already adds
that penalty to the storage stack for us because they don't have a
linear LBA-to-physical location characteristic.  Hence we can
increase filesystem concurrency without addition performance
penalties being incurred.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

  parent reply	other threads:[~2018-08-01  5:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01  1:32 agcount 33 by default for a single HDD? Chris Murphy
2018-08-01  2:01 ` Chris Murphy
2018-08-01  4:12 ` Dave Chinner [this message]
2018-08-01  4:38   ` Chris Murphy
2018-08-01  4:41     ` Eric Sandeen
2018-08-01  5:04       ` Chris Murphy
2018-08-01  5:05         ` Eric Sandeen
2018-08-01 11:45         ` Carlos Maiolino
2018-08-01 18:50           ` Chris Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180801041204.GH2234@dastard \
    --to=david@fromorbit.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=lists@colorremedies.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).