From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: xfs <linux-xfs@vger.kernel.org>
Subject: [PATCH] xfs: only validate summary counts on primary superblock
Date: Wed, 1 Aug 2018 16:18:55 -0700 [thread overview]
Message-ID: <20180801231855.GL30972@magnolia> (raw)
From: Darrick J. Wong <darrick.wong@oracle.com>
Skip the summary counter checks for secondary superblocks because
userspace has always written the secondary supers with zeroed counters.
mkfs.xfs fails immediately without this patch.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/xfs/libxfs/xfs_sb.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c
index ca1b3a7a9171..47e1dd4a5009 100644
--- a/fs/xfs/libxfs/xfs_sb.c
+++ b/fs/xfs/libxfs/xfs_sb.c
@@ -148,6 +148,7 @@ xfs_validate_sb_read(
STATIC int
xfs_validate_sb_write(
struct xfs_mount *mp,
+ struct xfs_buf *bp,
struct xfs_sb *sbp)
{
/*
@@ -155,10 +156,13 @@ xfs_validate_sb_write(
* the superblock. We skip this in the read validator because there
* could be newer superblocks in the log and if the values are garbage
* even after replay we'll recalculate them at the end of log mount.
+ * We only check the primary superblock to allow userspace tools to
+ * write secondary superblocks with zeroed counters.
*/
- if (sbp->sb_fdblocks > sbp->sb_dblocks ||
- !xfs_verify_icount(mp, sbp->sb_icount) ||
- sbp->sb_ifree > sbp->sb_icount) {
+ if (XFS_BUF_ADDR(bp) == XFS_SB_DADDR &&
+ (sbp->sb_fdblocks > sbp->sb_dblocks ||
+ !xfs_verify_icount(mp, sbp->sb_icount) ||
+ sbp->sb_ifree > sbp->sb_icount)) {
xfs_warn(mp, "SB summary counter sanity check failed");
return -EFSCORRUPTED;
}
@@ -756,7 +760,7 @@ xfs_sb_write_verify(
error = xfs_validate_sb_common(mp, bp, &sb);
if (error)
goto out_error;
- error = xfs_validate_sb_write(mp, &sb);
+ error = xfs_validate_sb_write(mp, bp, &sb);
if (error)
goto out_error;
next reply other threads:[~2018-08-02 1:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 23:18 Darrick J. Wong [this message]
2018-08-02 1:05 ` [PATCH] xfs: only validate summary counts on primary superblock Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801231855.GL30972@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).