From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f68.google.com ([209.85.221.68]:36533 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727388AbeHGNbQ (ORCPT ); Tue, 7 Aug 2018 09:31:16 -0400 Received: by mail-wr1-f68.google.com with SMTP id h9-v6so15415364wro.3 for ; Tue, 07 Aug 2018 04:17:25 -0700 (PDT) Date: Tue, 7 Aug 2018 13:17:21 +0200 From: Carlos Maiolino Subject: Re: [PATCH] design: Document project quota inode Message-ID: <20180807111721.phuphqqc4mt4uv4h@odin.usersys.redhat.com> References: <20180806211032.16777-1-mbenatto@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180806211032.16777-1-mbenatto@redhat.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Marco Benatto Cc: linux-xfs@vger.kernel.org, darrick.wong@oracle.com On Mon, Aug 06, 2018 at 06:10:32PM -0300, Marco Benatto wrote: > A project quota inode was introduced into V5 superblock allowing > project quotas and group quotas to be used simultaneously. However > on "Quota Inodes" section we still mention it's not possible to > use project and group quotas at sametime. > > This patch documents this behavior for V5 and later superblocks, > while keeps documented the old behavior for earlier versions. > > Signed-off-by: Marco Benatto > --- > design/XFS_Filesystem_Structure/internal_inodes.asciidoc | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/design/XFS_Filesystem_Structure/internal_inodes.asciidoc b/design/XFS_Filesystem_Structure/internal_inodes.asciidoc > index f5c2654..b694e74 100644 > --- a/design/XFS_Filesystem_Structure/internal_inodes.asciidoc > +++ b/design/XFS_Filesystem_Structure/internal_inodes.asciidoc > @@ -8,9 +8,12 @@ accessible from the superblock. > [[Quota_Inodes]] > == Quota Inodes > > -If quotas are used, two inodes are allocated for user and group quota > -management. If project quotas are used, these replace the group quota management > -and therefore uses the group quota inode. > +If quotas are used, prior to version 5 superblocks, two inodes are allocated for > +user and group management. In this case if project quotas are used, these replace > +the group quota management and therefore uses the group quota inode. > + > +In version 5 superblock or later a third inode will be allocated to project quota > +management, making it possible to use group and project quotas management simultaneously. This is mostly ok, but I wonder we the V5 behavior should be emphasized, instead of V4 behavior? > > * Project quota's primary purpose is to track and monitor disk usage for > directories. For this to occur, the directory inode must have the > @@ -28,7 +31,7 @@ multiplied by the size of +xfs_dqblk_t+ (136 bytes). > .Quota inode layout > image::images/76.png[] > > -Quota information is stored in the data extents of the two reserved quota > +Quota information is stored in the data extents of the reserved quota > inodes as an array of the +xfs_dqblk+ structures, where there is one array > element for each ID in the system: > > -- > 2.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Carlos