From: Carlos Maiolino <cmaiolino@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/6] xfs: recalculate summary counters at mount time if icount is bad
Date: Mon, 13 Aug 2018 09:46:03 +0200 [thread overview]
Message-ID: <20180813074603.snvyddbl2z2xmp7t@odin.usersys.redhat.com> (raw)
In-Reply-To: <153400170370.27471.3984686896617555055.stgit@magnolia>
On Sat, Aug 11, 2018 at 08:35:03AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Since the sb write verifier trips on bad icounts, we should also force a
> mount time recalculation of the summary counters if the icount is bad.
> This helps us avoid blowing up at freeze/unmount time when the bad
> counter gets written back out.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/xfs_mount.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
>
>
> diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
> index 99db27d6ac8a..02d15098dbee 100644
> --- a/fs/xfs/xfs_mount.c
> +++ b/fs/xfs/xfs_mount.c
> @@ -637,6 +637,7 @@ xfs_check_summary_counts(
> */
> if (XFS_LAST_UNMOUNT_WAS_CLEAN(mp) &&
> (mp->m_sb.sb_fdblocks > mp->m_sb.sb_dblocks ||
> + !xfs_verify_icount(mp, mp->m_sb.sb_icount) ||
> mp->m_sb.sb_ifree > mp->m_sb.sb_icount))
> mp->m_flags |= XFS_MOUNT_BAD_SUMMARY;
>
>
--
Carlos
next prev parent reply other threads:[~2018-08-13 10:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-11 15:34 [PATCH v2 0/6] xfs-4.19: various fixes Darrick J. Wong
2018-08-11 15:35 ` [PATCH 1/6] xfs: recalculate summary counters at mount time if icount is bad Darrick J. Wong
2018-08-12 7:53 ` Allison Henderson
2018-08-13 7:46 ` Carlos Maiolino [this message]
2018-08-11 15:35 ` [PATCH 2/6] xfs: xrep_findroot_block should reject root blocks with siblings Darrick J. Wong
2018-08-12 7:53 ` Allison Henderson
2018-08-13 7:48 ` Carlos Maiolino
2018-08-13 16:56 ` Brian Foster
2018-09-27 23:20 ` Darrick J. Wong
2018-08-11 15:35 ` [PATCH 3/6] xfs: sanity check ag header values in xrep_calc_ag_resblks Darrick J. Wong
2018-08-12 7:55 ` Allison Henderson
2018-08-13 7:52 ` Carlos Maiolino
2018-08-11 15:35 ` [PATCH 4/6] xfs: fix buffer state management in xrep_findroot_block Darrick J. Wong
2018-08-12 7:53 ` Allison Henderson
2018-08-13 8:05 ` Carlos Maiolino
2018-08-13 16:56 ` Brian Foster
2018-09-28 0:32 ` Darrick J. Wong
2018-08-13 22:56 ` Dave Chinner
2018-09-28 0:28 ` Darrick J. Wong
2018-08-11 15:35 ` [PATCH 5/6] iomap: fix WARN_ON_ONCE on uninitialized variable Darrick J. Wong
2018-08-12 7:55 ` Allison Henderson
2018-08-13 8:07 ` Carlos Maiolino
2018-08-11 15:35 ` [PATCH 6/6] xfs: don't crash the vfs on a garbage inline symlink Darrick J. Wong
2018-08-12 7:54 ` Allison Henderson
2018-08-13 7:23 ` Christoph Hellwig
2018-09-28 0:31 ` Darrick J. Wong
2018-08-19 21:07 ` Xu, Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180813074603.snvyddbl2z2xmp7t@odin.usersys.redhat.com \
--to=cmaiolino@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).