From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Matthias Bodenbinder <matthias@bodenbinder.de>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: Re: xfs_scrub_all warning
Date: Fri, 31 Aug 2018 09:45:35 -0700 [thread overview]
Message-ID: <20180831164535.GA4355@magnolia> (raw)
In-Reply-To: <974f65da-60f9-55aa-2e27-3fe9abb64f97@bodenbinder.de>
[add linux-xfs to cc]
On Fri, Aug 31, 2018 at 07:31:25AM +0200, Matthias Bodenbinder wrote:
> Hello Darrick,
>
> you are named as maintainer in the xfs_scrub_all python script which is
> coming with Manjaro Linux. Therefore I am writing to you about a
> "cosmetic" issue with invalid unit names.
>
> I have / and /home setup as XFS. When I run the script I get the
> following output:
>
> 1# xfs_scrub_all
> Scrubbing /home...
> Invalid unit name "xfs_scrub@/home" was escaped as "xfs_scrub@-home"
> (maybe you should use systemd-escape?)
Oh, lovely, systemd changed their escaping rules again...
> Starting Online XFS Metadata Check for /home...
> EXPERIMENTAL xfs_scrub program in use! Use at your own risk!
> Info: AG 1 superblock: Optimization is possible.
> Info: AG 2 superblock: Optimization is possible.
> Info: AG 3 superblock: Optimization is possible.
> Scrubbing /home done, (err=0)
> Scrubbing /...
> Invalid unit name "xfs_scrub@/" was escaped as "xfs_scrub@-" (maybe you
> should use systemd-escape?)
> Started Online XFS Metadata Check for /home.
> Scrubbing / done, (err=0)
>
> Can you fix that?
I think so. If you remove the lines:
if '-' not in path:
return path
from systemd_escape() in /sbin/xfs_scrub_all, do the warnings go away?
Does scrub still work afterwards?
--D
>
> Thanks
>
> Matthias
>
>
next parent reply other threads:[~2018-08-31 20:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <974f65da-60f9-55aa-2e27-3fe9abb64f97@bodenbinder.de>
2018-08-31 16:45 ` Darrick J. Wong [this message]
2018-09-01 10:45 ` xfs_scrub_all warning Matthias Bodenbinder
2018-10-01 17:08 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180831164535.GA4355@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=matthias@bodenbinder.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).