From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Jan Tulak <jtulak@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>,
Eric Sandeen <sandeen@sandeen.net>
Subject: Re: [PATCH 2/2] mkfs: move 'mounted' check before 'existing fs' check
Date: Thu, 20 Sep 2018 13:03:08 -0700 [thread overview]
Message-ID: <20180920200308.GJ20086@magnolia> (raw)
In-Reply-To: <CACj3i73ARZddDcCp9BJ626eo3v4N-dy535qSRLZUPT3==rdZjA@mail.gmail.com>
On Wed, Sep 19, 2018 at 05:05:38PM +0200, Jan Tulak wrote:
> On Wed, Sep 19, 2018 at 4:49 PM Darrick J. Wong <darrick.wong@oracle.com> wrote:
> >
> > On Wed, Sep 19, 2018 at 02:56:17PM +0200, Jan Tulak wrote:
> > > Check if a device is mounted (and issue an error about that) before
> > > asking for -f flag.
> > >
> > > Example of the old behaviour I'm changing:
> > > $ mkfs.xfs /dev/sda1
> > > mkfs.xfs: /dev/sda1 appears to contain an existing filesystem (xfs).
> > > mkfs.xfs: Use the -f option to force overwrite.
> > >
> > > $ mkfs.xfs -f /dev/sda1
> > > mkfs.xfs: /dev/sda1 contains a mounted filesystem
> >
> > I'm confused by the commit message -- what is the new behavior?
> >
> > Is it this?
> >
> > $ mkfs.xfs /dev/sda1
> > mkfs.xfs: /dev/sda1 contains a mounted filesystem
> >
> > $ mkfs.xfs -f /dev/sda1
> > mkfs.xfs: /dev/sda1 contains a mounted filesystem
>
> Yes. I should put it right into the commit message.
With that added,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
>
> Jan
>
> --
> Jan Tulak
> jtulak@redhat.com / jan@tulak.me
next prev parent reply other threads:[~2018-09-21 1:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 12:56 [PATCH 1/2] mkfs: discard only after all validations Jan Tulak
2018-09-19 12:56 ` [PATCH 2/2] mkfs: move 'mounted' check before 'existing fs' check Jan Tulak
2018-09-19 14:48 ` Darrick J. Wong
2018-09-19 15:05 ` Jan Tulak
2018-09-20 20:03 ` Darrick J. Wong [this message]
2018-09-19 14:44 ` [PATCH 1/2] mkfs: discard only after all validations Darrick J. Wong
2018-09-19 15:11 ` Jan Tulak
2018-09-20 3:16 ` Dave Chinner
2018-09-20 9:20 ` [PATCH 1/2 v2] " Jan Tulak
2018-09-20 20:03 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920200308.GJ20086@magnolia \
--to=darrick.wong@oracle.com \
--cc=jtulak@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox