From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] scrub: remove redundant debug test
Date: Wed, 26 Sep 2018 16:12:01 -0700 [thread overview]
Message-ID: <20180926231201.GX20086@magnolia> (raw)
In-Reply-To: <61fa5fe2-0ad9-80b2-f009-68a37682468d@sandeen.net>
On Wed, Sep 26, 2018 at 04:25:12PM -0500, Eric Sandeen wrote:
> From: Eric Sandeen <sandeen@redhat.com>
>
> debug_tweak_on() already tests for debug.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
>
> diff --git a/scrub/xfs_scrub.c b/scrub/xfs_scrub.c
> index 076a86a..33b83a5 100644
> --- a/scrub/xfs_scrub.c
> +++ b/scrub/xfs_scrub.c
> @@ -425,7 +425,7 @@ run_scrub_phases(
> unsigned int nr_threads;
> int rshift;
>
> - if (debug && debug_tweak_on("XFS_SCRUB_PHASE"))
> + if (debug_tweak_on("XFS_SCRUB_PHASE"))
> debug_phase = atoi(getenv("XFS_SCRUB_PHASE"));
>
> /* Run all phases of the scrub tool. */
>
next prev parent reply other threads:[~2018-09-27 5:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 21:23 [PATCH 0/2] xfsprogs: env var stuff Eric Sandeen
2018-09-26 21:25 ` [PATCH 1/2] scrub: remove redundant debug test Eric Sandeen
2018-09-26 23:12 ` Darrick J. Wong [this message]
2018-09-26 21:27 ` [PATCH 2/2] xfsprogs: document environment variables Eric Sandeen
2018-09-26 23:13 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180926231201.GX20086@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).