linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Matthias Bodenbinder <matthias@bodenbinder.de>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: Re: xfs_scrub_all warning
Date: Mon, 1 Oct 2018 10:08:23 -0700	[thread overview]
Message-ID: <20181001170823.GA5883@magnolia> (raw)
In-Reply-To: <14ac54ca-4f2d-c3a2-9157-93ae7e274f47@bodenbinder.de>

On Sat, Sep 01, 2018 at 12:45:54PM +0200, Matthias Bodenbinder wrote:
> Am 31.08.18 um 18:45 schrieb Darrick J. Wong:
> > I think so.  If you remove the lines:
> > 
> > 	if '-' not in path:
> > 		return path
> > 
> > from systemd_escape() in /sbin/xfs_scrub_all, do the warnings go away?
> > Does scrub still work afterwards?
> 
> That does work:
>  
> 8# ./my-xfs_scrub_all
> Scrubbing /home...
> Failed to add filter for units: No data available
> Scrubbing /home done, (err=0)
> 
> 
> But what is this "Failed to add filter..." message about?

I /think/ that's journalctl failing to construct a filter for
'xfs_scrub@*' to display whatever output comes out of running the
xfs_scrub jobs.  I'll look further into it, but for now I've posted the
fix to xfs_scrub_all to shut up the escaping complaints.

--D

> Thanks for your help
> Matthias
> 

      reply	other threads:[~2018-10-01 23:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <974f65da-60f9-55aa-2e27-3fe9abb64f97@bodenbinder.de>
2018-08-31 16:45 ` xfs_scrub_all warning Darrick J. Wong
2018-09-01 10:45   ` Matthias Bodenbinder
2018-10-01 17:08     ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181001170823.GA5883@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=matthias@bodenbinder.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).