From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Stefan Ring <stefanrin@gmail.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/1] xfs_metadump: Zap more stale data
Date: Sun, 7 Oct 2018 09:21:27 -0700 [thread overview]
Message-ID: <20181007162127.GE28243@magnolia> (raw)
In-Reply-To: <CAAxjCEx1LemxZPSE5h2ZreNmfOuh09FQBJ=ZoPXJLr=2PTW=SA@mail.gmail.com>
On Sun, Oct 07, 2018 at 01:57:10PM +0200, Stefan Ring wrote:
> On Sun, Oct 7, 2018 at 11:43 AM Stefan Ring <stefanrin@gmail.com> wrote:
> >
> > Interestingly my file system has dirblklog = 0. I guess I'll have to
> > start creating some toy file system images for experimentation.
>
> Ok, I've found out how to create one with dirblklog > 0, but the
> default seems to be, and have been for a very long time, zero
> (directory blocks are the same size as file system blocks). I'm afraid
> of uncovering all kinds of nastiness going this untrodden path…
Nothing is ever simple in xfs, sadly. :/
That said, I think the "recommended" ceph configuration still has
multiblock directories, so I think those code paths are somewhat
frequently used by some of the users.
(I guess you could temporarily change the patch to memset(buf, 'a', ...)
to make sure it only ever touches the empty parts of the dir block buffer.)
--D
next prev parent reply other threads:[~2018-10-07 23:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 20:57 [PATCH 0/1] Try to squash metadump data leaks Stefan Ring
2018-10-04 20:57 ` [PATCH 1/1] xfs_metadump: Zap more stale data Stefan Ring
2018-10-04 22:23 ` Darrick J. Wong
2018-10-05 20:46 ` Stefan Ring
2018-10-05 20:57 ` Darrick J. Wong
2018-10-05 20:35 ` Stefan Ring
2018-10-05 20:40 ` Darrick J. Wong
2018-10-07 9:43 ` Stefan Ring
2018-10-07 11:57 ` Stefan Ring
2018-10-07 16:21 ` Darrick J. Wong [this message]
2018-10-10 9:37 ` Stefan Ring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181007162127.GE28243@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=stefanrin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).