From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/8] xfs: remove magic handling of unwritten extents in xfs_bmapi_allocate
Date: Mon, 8 Oct 2018 13:24:55 +1100 [thread overview]
Message-ID: <20181008022455.GD18095@dastard> (raw)
In-Reply-To: <20181007220258.GC18095@dastard>
On Mon, Oct 08, 2018 at 09:02:58AM +1100, Dave Chinner wrote:
> On Sun, Oct 07, 2018 at 12:13:19PM +0200, Christoph Hellwig wrote:
> > On Sat, Oct 06, 2018 at 11:43:31AM +0200, Christoph Hellwig wrote:
> > > I suspect the asserts actually are what is incorrect. But given
> > > how late we are in the cycle I've just dropped the patch and kicked
> > > off xfstests runs (now including rmap, sigh..).
> >
> > Without this patch test runs including rmap succeed. Do you want
> > me to resend with the patch dropped (thing should just apply without
> > it as-is).
>
> I'll drop it and see what happens...
Different problems after dropping that patch and re-instating the
rest of the series. The shutdown/io error stress tests now hang
randomly in unmount reclaiming inodes. e.g. generic/388:
.....
[ 4028.393874] XFS (pmem1): Mounting V5 Filesystem
[ 4028.397627] XFS (pmem1): Starting recovery (logdev: internal)
[ 4028.400436] XFS (pmem1): Ending recovery (logdev: internal)
[ 4028.406885] XFS (pmem1): xfs_do_force_shutdown(0x8) called from line 435 of file fs/xfs/libxfs/xfs_defer.c. Return address = ffffffff814fc998
[ 4028.406966] XFS (pmem1): xfs_imap_lookup: xfs_ialloc_read_agi() returned error -5, agno 0
[ 4028.500258] XFS (pmem1): Unmounting Filesystem
[ 4230.446548] INFO: task umount:16507 blocked for more than 120 seconds.
[ 4230.449820] Not tainted 4.19.0-rc7-dgc+ #682
[ 4230.452695] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
[ 4230.456142] umount D14552 16507 14540 0x00000000
[ 4230.458206] Call Trace:
[ 4230.458980] ? __schedule+0x2bf/0x8a0
[ 4230.459852] ? rwsem_down_write_failed+0x235/0x440
[ 4230.460815] ? rwsem_down_write_failed+0x230/0x440
[ 4230.461777] schedule+0x45/0x110
[ 4230.462597] rwsem_down_write_failed+0x235/0x440
[ 4230.463685] ? xfs_reclaim_inode+0x107/0x430
[ 4230.464549] ? call_rwsem_down_write_failed+0x13/0x20
[ 4230.465564] call_rwsem_down_write_failed+0x13/0x20
[ 4230.466599] down_write+0x37/0x50
[ 4230.467438] xfs_ilock+0x119/0x200
[ 4230.468133] xfs_reclaim_inode+0x107/0x430
[ 4230.468965] xfs_reclaim_inodes_ag+0x1bd/0x330
[ 4230.469870] xfs_reclaim_inodes+0x2b/0x50
[ 4230.470736] xfs_unmountfs+0x92/0x180
[ 4230.471682] xfs_fs_put_super+0x39/0xb0
[ 4230.472466] generic_shutdown_super+0x64/0x110
[ 4230.473368] kill_block_super+0x21/0x50
[ 4230.474149] deactivate_locked_super+0x39/0x70
[ 4230.475100] cleanup_mnt+0x3b/0x80
[ 4230.476004] task_work_run+0x82/0xb0
[ 4230.476740] exit_to_usermode_loop+0xd3/0xe0
[ 4230.477608] do_syscall_64+0x170/0x180
[ 4230.478421] entry_SYSCALL_64_after_hwframe+0x49/0xbe
And on a different machine, generic/475:
[ 8001.777349] XFS (dm-0): Unmounting Filesystem
[ 8001.850325] XFS (dm-0): Mounting V5 Filesystem
[ 8002.234755] XFS (dm-0): Starting recovery (logdev: internal)
[ 8002.410851] XFS (dm-0): Ending recovery (logdev: internal)
[ 8002.438481] XFS (dm-0): metadata I/O error in "xfs_trans_read_buf_map" at daddr 0xd60 len 8 error 5
[ 8002.438542] XFS (dm-0): metadata I/O error in "xfs_trans_read_buf_map" at daddr 0xa00728 len 8 error 5
[ 8002.441590] XFS (dm-0): metadata I/O error in "xfs_trans_read_buf_map" at daddr 0x1406f80 len 32 error 5
[ 8002.441597] XFS (dm-0): xfs_imap_to_bp: xfs_trans_read_buf() returned error -5.
[ 8002.442325] Buffer I/O error on dev dm-0, logical block 5242864, async page read
[ 8002.442377] XFS (dm-0): xfs_do_force_shutdown(0x1) called from line 327 of file fs/xfs/xfs_trans_buf.c. Return address = ffffffff8156e5e4
[ 8002.442422] XFS (dm-0): metadata I/O error in "xfs_trans_read_buf_map" at daddr 0x1e00080 len 32 error 5
[ 8002.442427] XFS (dm-0): xfs_imap_to_bp: xfs_trans_read_buf() returned error -5.
[ 8002.442443] XFS (dm-0): metadata I/O error in "xlog_iodone" at daddr 0x1402790 len 64 error 5
[ 8002.442448] XFS (dm-0): xfs_do_force_shutdown(0x2) called from line 1271 of file fs/xfs/xfs_log.c. Return address = ffffffff81558d45
[ 8002.442459] XFS (dm-0): xfs_imap_to_bp: xfs_trans_read_buf() returned error -5.
[ 8002.442480] XFS (dm-0): Log I/O Error Detected. Shutting down filesystem
[ 8002.442481] XFS (dm-0): Please umount the filesystem and rectify the problem(s)
[ 8002.525313] XFS (dm-0): Unmounting Filesystem
[ 8217.616288] INFO: task umount:11278 blocked for more than 120 seconds.
[ 8217.621420] Tainted: G W 4.19.0-rc7-dgc+ #682
[ 8217.622924] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
[ 8217.625024] umount D14640 11278 9205 0x00000080
[ 8217.626512] Call Trace:
[ 8217.627192] ? __schedule+0x2bf/0x8a0
[ 8217.628213] ? rwsem_down_write_failed+0x235/0x440
[ 8217.629512] ? rwsem_down_write_failed+0x230/0x440
[ 8217.630804] schedule+0x45/0x110
[ 8217.631673] rwsem_down_write_failed+0x235/0x440
[ 8217.632593] ? xfs_reclaim_inode+0x107/0x430
[ 8217.633429] ? call_rwsem_down_write_failed+0x13/0x20
[ 8217.634419] call_rwsem_down_write_failed+0x13/0x20
[ 8217.635361] down_write+0x37/0x50
[ 8217.636010] xfs_ilock+0x119/0x200
[ 8217.636702] xfs_reclaim_inode+0x107/0x430
[ 8217.637510] xfs_reclaim_inodes_ag+0x1bd/0x330
[ 8217.638391] ? _raw_spin_lock_irqsave+0x32/0x40
[ 8217.639276] ? __flush_work+0x194/0x1e0
[ 8217.640027] ? preempt_count_sub+0x43/0x50
[ 8217.640847] ? _raw_spin_unlock_irqrestore+0x2c/0x60
[ 8217.641815] ? del_timer+0x53/0x80
[ 8217.642490] ? __cancel_work_timer+0x13c/0x1e0
[ 8217.643354] ? xfs_ail_push_all_sync+0xcc/0xf0
[ 8217.644238] xfs_reclaim_inodes+0x2b/0x50
[ 8217.645025] xfs_unmountfs+0x92/0x180
[ 8217.645742] xfs_fs_put_super+0x39/0xb0
[ 8217.646490] generic_shutdown_super+0x64/0x110
[ 8217.647360] kill_block_super+0x21/0x50
[ 8217.648131] deactivate_locked_super+0x39/0x70
[ 8217.649006] cleanup_mnt+0x3b/0x80
[ 8217.649675] task_work_run+0x82/0xb0
[ 8217.650389] exit_to_usermode_loop+0xd3/0xe0
[ 8217.651223] do_syscall_64+0x170/0x180
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-10-08 9:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 17:41 delalloc and reflink fixes & tweaks V3 Christoph Hellwig
2018-10-02 17:42 ` [PATCH 1/8] xfs: remove XFS_IO_INVALID Christoph Hellwig
2018-10-02 17:42 ` [PATCH 2/8] xfs: remove suport for filesystems without unwritten extent flag Christoph Hellwig
2018-10-03 12:15 ` Brian Foster
2018-10-03 14:52 ` Darrick J. Wong
2018-10-03 14:54 ` Christoph Hellwig
2018-10-02 17:42 ` [PATCH 3/8] xfs: remove magic handling of unwritten extents in xfs_bmapi_allocate Christoph Hellwig
2018-10-03 12:15 ` Brian Foster
2018-10-06 9:34 ` Dave Chinner
2018-10-06 9:43 ` Christoph Hellwig
2018-10-07 10:13 ` Christoph Hellwig
2018-10-07 22:02 ` Dave Chinner
2018-10-08 2:24 ` Dave Chinner [this message]
2018-10-08 6:07 ` Dave Chinner
2018-10-02 17:42 ` [PATCH 4/8] xfs: handle zeroing in xfs_file_iomap_begin_delay Christoph Hellwig
2018-10-03 12:16 ` Brian Foster
2018-10-02 17:42 ` [PATCH 5/8] xfs: remove the unused shared argument to xfs_reflink_reserve_cow Christoph Hellwig
2018-10-02 17:42 ` [PATCH 6/8] xfs: remove the unused trimmed argument from xfs_reflink_trim_around_shared Christoph Hellwig
2018-10-02 17:42 ` [PATCH 7/8] xfs: fix fork selection in xfs_find_trim_cow_extent Christoph Hellwig
2018-10-02 17:42 ` [PATCH 8/8] xfs: print dangling delalloc extents Christoph Hellwig
2018-10-05 9:29 ` delalloc and reflink fixes & tweaks V3 Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008022455.GD18095@dastard \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).