From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:10744 "EHLO ipmail06.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725842AbeJHNRF (ORCPT ); Mon, 8 Oct 2018 09:17:05 -0400 Date: Mon, 8 Oct 2018 17:07:01 +1100 From: Dave Chinner Subject: Re: [PATCH 3/8] xfs: remove magic handling of unwritten extents in xfs_bmapi_allocate Message-ID: <20181008060701.GE18095@dastard> References: <20181002174207.25275-1-hch@lst.de> <20181002174207.25275-4-hch@lst.de> <20181006093433.GA18095@dastard> <20181006094331.GA5845@lst.de> <20181007101319.GA25721@lst.de> <20181007220258.GC18095@dastard> <20181008022455.GD18095@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181008022455.GD18095@dastard> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org On Mon, Oct 08, 2018 at 01:24:55PM +1100, Dave Chinner wrote: > On Mon, Oct 08, 2018 at 09:02:58AM +1100, Dave Chinner wrote: > > On Sun, Oct 07, 2018 at 12:13:19PM +0200, Christoph Hellwig wrote: > > > On Sat, Oct 06, 2018 at 11:43:31AM +0200, Christoph Hellwig wrote: > > > > I suspect the asserts actually are what is incorrect. But given > > > > how late we are in the cycle I've just dropped the patch and kicked > > > > off xfstests runs (now including rmap, sigh..). > > > > > > Without this patch test runs including rmap succeed. Do you want > > > me to resend with the patch dropped (thing should just apply without > > > it as-is). > > > > I'll drop it and see what happens... > > Different problems after dropping that patch and re-instating the > rest of the series. The shutdown/io error stress tests now hang > randomly in unmount reclaiming inodes. e.g. generic/388: Ah, my fault. False alarm. I had a patch that I knew was broken at the end of the series that I hadn't commented out. All prior testing was without it, but when I reset branch without this patch I simply popped everything back in, including the broken patch at the end. Retesting now. -Dave. -- Dave Chinner david@fromorbit.com