From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs: hard fail dax mount on unsupported devices
Date: Tue, 9 Oct 2018 09:10:11 +1100 [thread overview]
Message-ID: <20181008221011.GF18095@dastard> (raw)
In-Reply-To: <1539027169-23332-2-git-send-email-sandeen@sandeen.net>
On Mon, Oct 08, 2018 at 02:32:47PM -0500, Eric Sandeen wrote:
> As dax inches closer to production use, an administrator should not
> be surprised by silently disabling the feature they asked for.
>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---
> fs/xfs/xfs_super.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 207ee30..a0a32cd 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1674,9 +1674,9 @@ struct proc_xfs_info {
> rtdev_is_dax = bdev_dax_supported(
> mp->m_rtdev_targp->bt_bdev, sb->s_blocksize);
> if (!rtdev_is_dax && !datadev_is_dax) {
> - xfs_alert(mp,
> - "DAX unsupported by block device. Turning off DAX.");
> - mp->m_flags &= ~XFS_MOUNT_DAX;
> + xfs_alert(mp, "DAX unsupported by block device.");
> + error = -EINVAL;
> + goto out_filestream_unmount;
> }
> if (xfs_sb_version_hasreflink(&mp->m_sb)) {
> xfs_alert(mp,
Looks good, I'll throw it in the stack for 4.20.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-10-09 5:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 19:32 [PATCH 0/3] ext2, ext4, xfs: hard fail dax mount on unsupported devices Eric Sandeen
2018-10-08 19:32 ` [PATCH 1/3] " Eric Sandeen
2018-10-08 22:10 ` Dave Chinner [this message]
2018-10-08 19:32 ` [PATCH 2/3] ext4: " Eric Sandeen
2018-12-04 5:48 ` Theodore Y. Ts'o
2018-10-08 19:32 ` [PATCH 3/3] ext2: " Eric Sandeen
2018-10-11 10:36 ` [PATCH 0/3] ext2, ext4, xfs: " Jan Kara
2018-10-11 18:08 ` Dan Williams
2018-10-11 18:38 ` Eric Sandeen
2018-10-12 2:21 ` Theodore Y. Ts'o
2018-10-12 8:21 ` Christoph Hellwig
2018-10-13 16:05 ` Ross Zwisler
2018-10-17 19:42 ` Eric Sandeen
2018-10-17 19:51 ` Ross Zwisler
2018-10-17 19:52 ` Dan Williams
2018-10-17 21:31 ` Jeff Moyer
2018-10-17 21:44 ` Dan Williams
2018-10-18 1:05 ` Dave Chinner
2018-10-18 2:01 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008221011.GF18095@dastard \
--to=david@fromorbit.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).