linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Carlos Maiolino <cmaiolino@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH 0/2] xfs stats fixes - V2
Date: Wed, 10 Oct 2018 14:37:06 +0200	[thread overview]
Message-ID: <20181010123708.7632-1-cmaiolino@redhat.com> (raw)

Hi,

this is a new version of my fixes to xfsstats code, the V1 is here:
https://marc.info/?l=linux-xfs&m=153857014823217&w=2

This patchset main goal, is to fix a bug which makes /proc/fs/xfs/xqmstat to
display garbage data (patch 1), and a re-work of the offset marks in __xfsstats,
replacing the defines, by usage of offsetof(), as suggested by Eric and Dave.

Patch 2 isn't tagged as V2, because it's essentially different from the patch 2
of the first version. It still prevents offset mistakes in future updates of
__xfsstats, but in a different way than the V1 patchset

I'm not tagging stable here, because patch 2 only applies cleanly since 4.18


Carlos Maiolino (2):
  xfs: Fix xqmstats offsets in /proc/fs/xfs/xqmstat
  xfs: use offsetof() in place of offset macros for __xfsstats

 fs/xfs/xfs_stats.c | 52 +++++++++++++++++++++++++---------------------
 fs/xfs/xfs_stats.h | 28 +++----------------------
 2 files changed, 31 insertions(+), 49 deletions(-)

-- 
2.17.1

             reply	other threads:[~2018-10-10 19:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10 12:37 Carlos Maiolino [this message]
2018-10-10 12:37 ` [PATCH 1/2] xfs: Fix xqmstats offsets in /proc/fs/xfs/xqmstat Carlos Maiolino
2018-10-10 12:37 ` [PATCH 2/2] xfs: use offsetof() in place of offset macros for __xfsstats Carlos Maiolino
2018-10-10 14:49   ` Darrick J. Wong
2018-10-10 14:58     ` Carlos Maiolino
2018-10-10 15:02       ` Darrick J. Wong
2018-10-10 21:28         ` Dave Chinner
2018-10-11  5:29   ` Dave Chinner
2018-10-11 14:04     ` Eric Sandeen
2018-10-12  7:01       ` Dave Chinner
2018-10-12 15:00         ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181010123708.7632-1-cmaiolino@redhat.com \
    --to=cmaiolino@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).