From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:33810 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727529AbeJKN3l (ORCPT ); Thu, 11 Oct 2018 09:29:41 -0400 Date: Wed, 10 Oct 2018 23:03:58 -0700 From: Christoph Hellwig Subject: Re: [PATCH 16/18] xfs_scrub: remove shadow var from run_scrub_phases() Message-ID: <20181011060358.GP20811@infradead.org> References: <1539201682-22198-1-git-send-email-sandeen@redhat.com> <1539201682-22198-17-git-send-email-sandeen@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1539201682-22198-17-git-send-email-sandeen@redhat.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Eric Sandeen Cc: linux-xfs@vger.kernel.org On Wed, Oct 10, 2018 at 03:01:20PM -0500, Eric Sandeen wrote: > The local nr_threads shadows a global var of the same name. > Use a local variable to avoid confusion (even though estimate_work() > may simply fill in the value of the global...) > > Signed-off-by: Eric Sandeen Looks good, Reviewed-by: Christoph Hellwig