linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
	Ross Zwisler <zwisler@kernel.org>,
	Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH 0/3] ext2, ext4, xfs: hard fail dax mount on unsupported devices
Date: Thu, 11 Oct 2018 12:36:36 +0200	[thread overview]
Message-ID: <20181011103636.GC9467@quack2.suse.cz> (raw)
In-Reply-To: <1539027169-23332-1-git-send-email-sandeen@sandeen.net>

On Mon 08-10-18 14:32:46, Eric Sandeen wrote:
> In response to an earlier xfs patch to change how xfs reacts to
> dax incompatibilities, Dave said:
> 
> > I suspect we need to be more harsh are rejecting mounts with -o dax
> > on devices DAX isn't supported on. This mount option is going into
> > production systems - it's not just for "testing" as the comments all
> > claim. i Things will break in production systems if DAX isn't
> > enabled and they are expecting it to be enabled.
> 
> and I tend to agree, so proposing this change to hard-fail a dax mount if
> the device doesn't support it, instead of silently disabling the
> functionality.  Proposing for ext2, ext4, and xfs to keep behavior in
> sync.

Let me include Dan and Ross into the discussion since they were the ones
proposing the "silent fallback" behavior (ext4 actually did fail the mount
instead not so long ago - see 24f3478d664b "ext4: auto disable dax instead
of failing mount" from December). Guys, why did you choose the fallback
path instead of a failure?

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

  parent reply	other threads:[~2018-10-11 18:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 19:32 [PATCH 0/3] ext2, ext4, xfs: hard fail dax mount on unsupported devices Eric Sandeen
2018-10-08 19:32 ` [PATCH 1/3] " Eric Sandeen
2018-10-08 22:10   ` Dave Chinner
2018-10-08 19:32 ` [PATCH 2/3] ext4: " Eric Sandeen
2018-12-04  5:48   ` Theodore Y. Ts'o
2018-10-08 19:32 ` [PATCH 3/3] ext2: " Eric Sandeen
2018-10-11 10:36 ` Jan Kara [this message]
2018-10-11 18:08   ` [PATCH 0/3] ext2, ext4, xfs: " Dan Williams
2018-10-11 18:38     ` Eric Sandeen
2018-10-12  2:21       ` Theodore Y. Ts'o
2018-10-12  8:21       ` Christoph Hellwig
2018-10-13 16:05         ` Ross Zwisler
2018-10-17 19:42           ` Eric Sandeen
2018-10-17 19:51             ` Ross Zwisler
2018-10-17 19:52             ` Dan Williams
2018-10-17 21:31             ` Jeff Moyer
2018-10-17 21:44               ` Dan Williams
2018-10-18  1:05                 ` Dave Chinner
2018-10-18  2:01                   ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181011103636.GC9467@quack2.suse.cz \
    --to=jack@suse.cz \
    --cc=dan.j.williams@intel.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    --cc=zwisler@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).