From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] xfsprogs: enable sparse checking with make C=1
Date: Sun, 14 Oct 2018 10:08:18 -0700 [thread overview]
Message-ID: <20181014170818.GA30673@infradead.org> (raw)
In-Reply-To: <97a4f428-9c9c-7bd7-7d6f-f2bf3a39b9ac@redhat.com>
On Thu, Oct 11, 2018 at 11:12:52AM -0500, Eric Sandeen wrote:
> Enable "make C=1" sparse checking when files get rebuilt. To check
> all files, run "make clean" first.
>
> This is a bit simpler than redefining CC for the whole build, which
> requires extra commandline definitions and apparently is enough of a
> barrier that nobody's doing sparse checking.
>
> Note, this requires unreleased sparse after v0.5, which enables the
> CHAR_BIT definition; otherwise it chokes.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2018-10-15 0:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 16:10 [PATCH 0/2] xfsprogs: enable sparse checking with "make C=[12]" Eric Sandeen
2018-10-11 16:12 ` [PATCH 1/2] xfsprogs: enable sparse checking with make C=1 Eric Sandeen
2018-10-12 8:22 ` Carlos Maiolino
2018-10-14 17:08 ` Christoph Hellwig [this message]
2018-10-11 16:14 ` PATCH 2/2] xfsprogs: enable sparse checking with "make C=2" Eric Sandeen
2018-10-12 8:23 ` Carlos Maiolino
2018-10-14 17:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181014170818.GA30673@infradead.org \
--to=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).